[Cs-studio-core] RightsManagementService listeners never used? Re: Memory leak in org.csstudio.platform.*.security

[Kasemir, K. <kas...@or...>]

Hi:

Looking at the RightsManagementService , I was about to replace the listener
list in there with a weak-link list to prevent memory leaks with for example
AbstractUserDependentAction instances that are used in dynamically created
context menues which register, but have no good way to ever unregister.

Then I noticed that the RightsManagementService._listener list is never
used:
The AbstractUserDependentAction registers in the list, maybe others do, too.
In principle there is an API to unregister, but the listeners are never
invoked.

So the easiest fix would be to simply delete the
RightsManagementService._listener list (and add/removeListener calls).

Anybody opposed to this?

Thanks,
Kay


On 6/24/10 09:24 , "Kay Kasemir" <kas...@or...> wrote:

> Hi:
> 
> I've updated the ActivationService  (ActivatableList, ObjectAdapterTupel) to
> use WeakReferences to the registered objects, so according to JProfiler it no
> longer keeps actions from being garbage collected.
> 
> But it turns out that the CSS SecurityFacade and RightsManagementService also
> use hard references to each AbstractUserDependentAction, so I'll try to update
> those as well.
> 
> Thanks,
> Kay