Re: [CryptoAPI-devel] IDEA patch

[Herbert V. R. <hv...@hv...>]

On Tue, 2002-04-02 at 23:57, Gisle S{lensminde wrote:
> Here is a patch to make idea work again - that is - I swaped the code
> for big endian and little endian handling, and that seemed to be
> sufficient to get IDEA to work. With this patch it reproduces the
> test vectors. There is no handling of endianness in the key schedule, so
> it will probably not work on big endian systems.
thx!...
=20
> The thing I wrote about the IDEA key schedule was wrong. I was confused
> by pointer aritmetrics on the input parameter. Bad coding style, but the
> code worked.
...based on your fix I've cleaned up the idea cipher, and made it
endian-safe... and got rid of those #ifdef's.... should have become even
more readable now... (maybe it lost a bit of performance, but at the
moment correctness is more important to me than speed... ;-)

regards,
--=20
Herbert Valerio Riedel       /    Phone: (EUROPE) +43-1-58801-18840
Email: hv...@hv...       /    Finger hv...@gn... for GnuPG Public Key
GnuPG Key Fingerprint: 7BB9 2D6C D485 CE64 4748  5F65 4981 E064 883F
4142