Thank you for submitting the patch. A few comments:
Why does the help text for 'scriptkillall' say "Not guaranteed to work?"
Keep style in mind in script_killall_wrapper(): consistent indentation, no space before ';', and no extra space around the parenthesis in the function declaration.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
1) I just copied the help text from "help_scriptkill()" to "help_scriptkillall()" with some adjustments. If a client with a running script crashed or exited incorrectly , the script will continue running detached and can no longer be killed by scriptkill or scriptkillall commands. So in any case, the user must check if the scripts are still running in the background.
2) Here is a patch with corrected style. If it is too late , then I also send a patch that only corrects this.
Thank you for submitting the patch. A few comments:
1) I just copied the help text from "help_scriptkill()" to "help_scriptkillall()" with some adjustments. If a client with a running script crashed or exited incorrectly , the script will continue running detached and can no longer be killed by scriptkill or scriptkillall commands. So in any case, the user must check if the scripts are still running in the background.
2) Here is a patch with corrected style. If it is too late , then I also send a patch that only corrects this.
Committed in 17769c0, thanks!