Here's a mining skill I made. Includes the skill, tool, mountains you can mine, a unique arch which comes off the mountain and a TRS entry.
Instructions included.
Unrelated but I didn't want to make an entirely new entry.
This is a one time use potion bottle which breaks into shards when it's used. Includes a 'cracked generic potion bottle' and a new arch & image for glass rubble. (Thanks Saiapatsu!)
I just noticed a mistake with that skill arch that will cause a crash but it's an easy fix!
Open the mining skill and look where it says type (not subtype), see the number 39 there? That needs to be a 43. That's it!
Otherwise feedback appreciated.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
The patch looks fine, but I'm reluctant to add many skills for such harvesting.
The generic "harvesting" skill should cover all those mining/woodcutting ones, but there seems to be an issue on the server with multiple skills of the same subtype, I'm concerned clients would be impacted.
Thus I'd first like to fix the server/client, then commit without the need to change the skill.h file like this patch does.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Unrelated but I didn't want to make an entirely new entry.
This is a one time use potion bottle which breaks into shards when it's used. Includes a 'cracked generic potion bottle' and a new arch & image for glass rubble. (Thanks Saiapatsu!)
Patch and file moved to https://sourceforge.net/p/crossfire/patches/367/
I just noticed a mistake with that skill arch that will cause a crash but it's an easy fix!
Open the mining skill and look where it says type (not subtype), see the number 39 there? That needs to be a 43. That's it!
Otherwise feedback appreciated.
The patch looks fine, but I'm reluctant to add many skills for such harvesting.
The generic "harvesting" skill should cover all those mining/woodcutting ones, but there seems to be an issue on the server with multiple skills of the same subtype, I'm concerned clients would be impacted.
Thus I'd first like to fix the server/client, then commit without the need to change the skill.h file like this patch does.
We both know that the server change you're talking about won't happen so why not just accept the skill.
Patch applied, with some changes (subtype of mining is now the generic "harvesting" one instead of a new skill).