Menu

#258 Bargaining experience for selling items awarded too stringently

closed
nobody
server (84)
5
False
2021-07-21
2018-01-10
SilverNexus
No

In shop.c, it appears that bargaining experience for selling an item is awarded based on the difference between the sell price and the base_price, in the amount in the player's favor. As a result, it tends to be nigh impossible to gain experience in bargaining from selling.
Since selling yields roughly half the base price (per the shop_price_sell method), this means that an item would have to be sold for twice the intended price to gain bargaining experience. Since the experience is also divided by 10, the item would have to be sold at >= 1 gold coin over the base price to gain any experience. In short, this never occurs, even at maximum Charisma.
Shop buy is not as clear, but seems to be functional, albeit highly dependent on shop friendliness and specialization.

Discussion

  • Kevin Zheng

    Kevin Zheng - 2019-01-12
    • labels: --> server
    • Group: --> 2.x
     
  • Kevin Zheng

    Kevin Zheng - 2019-12-28

    Ticket moved from /p/crossfire/bugs/845/

    Can't be converted:

    • _milestone: 2.x
     
  • Nicolas Weeger

    Nicolas Weeger - 2021-01-14

    Hello.

    Here's a patch changing how experience is awarded.

    Player gets up to 10% reduction (when buying items) or increase (when selling items) on price, randomly computed, and this reduction translates to experience in bargaining.

    Exact price variation is random(10% * bargaining level / max level).

    I also changed the messages when buying or selling to reflect price changes.

    A simple test showed that I had to buy for ~50000 platinum to get 50% of the first level. This may need to be adjusted...

    Edit on 01-16: patch updated, some leftover.

     

    Last edit: Nicolas Weeger 2021-01-16
  • Nicolas Weeger

    Nicolas Weeger - 2021-02-27
    • status: open --> patched
    • Sponsored: --> False
     
  • Nicolas Weeger

    Nicolas Weeger - 2021-02-27

    Patch committed with r22008.

     
  • Nicolas Weeger

    Nicolas Weeger - 2021-07-21
    • status: patched --> closed
     

Log in to post a comment.