#37 "greedy" autopickup
Added a new option, "greedy_autopickup", which will let you autopickup objects already underfoot without having to step onto them (but still respecting the safe and no-burden autopickup options). I had two motivations for this:
1) To autopickup newly butchered chunks of flesh without having to step off of them and back on.
2) So that if I step onto an item which I should autopickup, but moving onto it brings into view a hostile monster and I have safe_autopickup set, then if I kill the monster from a distance without moving off the item, thus making it safe again, autopickup will invoke and get it without moving off the square.
It also causes any acquirement items that match the autopickup conditions to be immediately picked up, but that's a side effect. While I was at it, I made it apply to god gifts that appear underfoot.
Included in the patch is the new wizard command '!', which forces a god gift without regard to (or changing) penance, piety or gift timeout.
diff vs svn
Logged In: YES
user_id=1562822
Originator: NO
The ; command already applies autopickup to the current square, so I'm not sure how important greedy_autopickup is. I haven't looked at the patch yet, but I guess this applies autopickup on commands like . and s?
Logged In: YES
user_id=53733
Originator: YES
<<<The ; command already applies autopickup to the current square, so I'm not sure how important greedy_autopickup is.>>>
Huh, I've been playing all this time and there's still commands I don't know about. Still, I'm kinda lazy (and also sometimes forget), so I prefer to have an option do it for me.
<<<I haven't looked at the patch yet, but I guess this applies autopickup on commands like . and s?>>>
Actually, it only does in in three places:
1) In input() in acr.cc, where it checks need_to_autopickup() to see if it should call autopickup(), it also checks to see if Options.greedy_autopickup is set, and does it if either is true. So, basically, any time the user enters a command.
2) At the end of finish_delay() in delay.cc, if Options.greedy_autopickup is set and you.turn_is_over *isn't* set, then it invokes autopickup().
3) It does the same at the end of do_god_gift() in religion.cc, so the player can scoop up god gifts without having to stop auto-explore or travel (though why the user wouldn't want to look at the gift right away I don't know).
Matthew, is there anything in here which hasn't made it into trunk?