C99 fixes for echolinux
no problem. i don't mind testing i can help. i haven't had time to look at the code yet, but it's a (relatively) simple buffer overflow so maybe einstead of using strcpy, use strncpy with the size of the buffer should fix it. oh and it's the bridge, not TLB, unless im missing something :D
I can help with testing. I can have a digital ocean droplet up and running in 2 minutes. Let me know which operating system you want, and I'll send you the login info. DE VE1DRU On Fri, Feb 7, 2020, 4:54 PM Skip Hansen, wb6ymh@users.sourceforge.net wrote: Hi Charles, Thanks for the detailed report! This might be enough to fix the issue. I'll try to find time in the next week or so. I no longer have a running testbed and I never ran thelinkbox on a 64 bit machine in any case so I will need help testing....
Hi Charles, Thanks for the detailed report! This might be enough to fix the issue. I'll try to find time in the next week or so. I no longer have a running testbed and I never ran thelinkbox on a 64 bit machine in any case so I will need help testing. If you can help test a future fix I'll send you some code. BTW I've moved to github: https://github.com/skiphansen/thelinkbox 73's Skip WB6YMH
ok update.. had chance to take a quick look at the core dump. it appears that the buffer used for messages coming from the server for disconnects is too small you can see where in line #6 where strcpy takes a crap because of the buffer overflow charlesb@UbuntuDev:~/echolink$ gdb /usr/local/bin/tbd core.current Reading symbols from /usr/local/bin/tbd...done. [New LWP 10187] [Thread debugging using libthread_db enabled] Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1". Core...
so here is what i get... been happening more lately now as far as the IP address, it doesn't matter that was just the last one, it appears to be mainly people that are coming in via a proxy or via cell phone etc. (my only way of testing). i've attached the core dump if anyone's interested Feb 7 2:38:30 RTP_Data: Failed to find client 44.190.12.83 Feb 7 2:38:30 Rejecting N1FBF, dir IP 44.137.75.243 != IP 44.190.12.83. Feb 7 2:38:30 Disconnecting unauthorized user N1FBF. CORE DUMPED - Buffer overf...
All I can say is that I believe the bridge only ran on 32bit OS. Its been a long time and I use allstarlink now for both echolink and asterisk services. You could make sure all permissions are setup correct. I will have to think on this for a while. 73s On Wed., Jan. 15, 2020, 1:52 p.m. Charles Blackburn, wx4cb@users.sourceforge.net wrote: is there any update to this? Just installed the latest version from SF and each time a user disconnects or times out the bridge core dumps. i'm working on getting...
Oh yes thats another thing, deb 9 had some major changes. Screwed up alot of running servers if one did a dist-upgrade. I was lucky i had read the release notes and tried on a non production machine first. Deb 9+ never worked. I am glad to hear you got it running on the 64bit. I wonder if ubuntu 18.04 is bases on debian 9? I dont have that info on my cell phone right now but worth checking into. On Wed., Jan. 15, 2020, 3:09 p.m. Drew, m0se5@users.sourceforge.net wrote: I just run mine on debian 8...
I just run mine on debian 8 64 bit... Works fine. On Wed, Jan 15, 2020, 11:52 AM Charles Blackburn, wx4cb@users.sourceforge.net wrote: is there any update to this? Just installed the latest version from SF and each time a user disconnects or times out the bridge core dumps. i'm working on getting some logs, but it's pretty much exactly as already been posted in here charlesb@UbuntuDev:~/echolink$ uname -a Linux UbuntuDev 4.15.0-64-generic #73-Ubuntu SMP Thu Sep 12 13:16:13 UTC 2019 x86_64 x86_64...
is there any update to this? Just installed the latest version from SF and each time a user disconnects or times out the bridge core dumps. i'm working on getting some logs, but it's pretty much exactly as already been posted in here charlesb@UbuntuDev:~/echolink$ uname -a Linux UbuntuDev 4.15.0-64-generic #73-Ubuntu SMP Thu Sep 12 13:16:13 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux charlesb@UbuntuDev:~/echolink$ cat /etc/lsb-release DISTRIB_ID=Ubuntu DISTRIB_RELEASE=18.04 DISTRIB_CODENAME=bionic DISTRIB_DESCRIPTION="Ubuntu...
Actually I had no problems with debian 8 64bit. But debian 9 64bit has been a no go for me every time. I suggest drew you look at all the changes between 8 and 9. There's some big ones. Maybe you can come up with a reason. I actually prefer 8 because it comes with MySQL and 9 comes with MariaDB so transitioning things that used to use the former is difficult and risky. G luck and Merry xmas. ----------- SIGNED ----------- -Doug- VE3GOB or VA3TDG Sudbury, Ontario, Canada 73s On Wed, Dec 12, 2018,...
Thanks Skip. It's certainly not a show stopper, just one of several things I wish there was some kind of definitive answer for. Jonathan hasn't been able to give me much beyond "read the source code for theBridge" and "read the RFCs". If I start crashing clients, I'll deal with that when the time comes. It looks like some of the padding was selected for the sake of encryption, but of course we're not using encryption in EchoLink.
Hi Scott, It's clear that Echolink is based on RTP, RTCP etc, but that was never stated. Echolink is a copy of an older Ham radio linking project called iLink and the protocol was considered a secret. EchoLink and thebridge, etc were based on reverse enginerring the over the air protocol, not RFCs or any other documentation. All I can say is that "it works", if changes were make to make it RFC compliant it may well stop working. Additionally I'm no longer developing this code and I'm no longer active...
Hi Drew, I appreciate the effort in reporting the crash, but basically neither thelinkbox nor thebridge were ever tested on 64 bit machines. The code was originally written 14 years ago when 64 bit machines were rare and expensive. I am not longer developing this code. If someone comes up with a fix I'd be more than happy to merge it, otherwise it's unlikely to get fixed anytime soon. 73's Skip WB6YMH
I've got some debug information here that may help with this .disconnect issue. - thebridge-1.09 - Ubuntu 18.04.1 LTS 64bit - Intel(R) Xeon(R) CPU E5-2650L v3 @ 1.80GHz make output: https://pastebin.com/pMpcCkAS syslog: systemd[1]: tbd.service: Main process exited, code=dumped, status=6/ABRT systemd[1]: tbd.service: Failed with result 'core-dump'. output from tbd -d: 2:50:49 DX-LINK disconnected by tbdcmd buffer overflow detected : tbd terminated Aborted (core dumped)
Sorry, I cannot try. I cannot upgrade to Debian 9 with risking destruction of the MySQL database On Fri, Nov 30, 2018 at 11:18 PM Drew m0se5@users.sourceforge.net wrote: Hi. Did you ever resolve this issue? I'm getting the same error. .disconnect will crash thebridge 1.06 running on Ubuntu 18.04.1 LTS 64 bit [support-requests:#7] thebridge1.09 and 1.06 .disconnect crash Status: open Group: v1.0 (example) Labels: tbd1.09 Crash .disconnect Created: Thu Mar 02, 2017 08:53 PM UTC by VE3GOB Last Updated:...
Try uding the most current versionof thebride. I ended up using debian 8 and it worked just fine. Funny you asked i forgot all about that issue and was going to do a dist-uprade tonight. I am using allstarlink right now but I could disable it for a few mins and rewnable cqi to see if it works for ya. I better take a snapshot of server first so it will be a while before i get back to you. But it will be tonight. ----------- SIGNED ----------- -Doug- VE3GOB or VA3TDG Sudbury, Ontario, Canada 73s On...
Hi. Did you ever resolve this issue? I'm getting the same error. .disconnect will crash thebridge 1.06 running on Ubuntu 18.04.1 LTS 64 bit
Incorrect padding calculation in GenBye()
thelinkbox
thebridge-1.09 tested with debian 8.8 x64. Works fine. Running on NOLP conference server for 1+ months
Tested with debian 8.8 x64. Works fine. Running on NOLP conference server for 1+ months
Hi Doug, I don't know if anyone has been running thelinkbox or thebridge on a 64...
Update: Tried UBUNTU Server 16,04 64bit = No Luck Update: Tried UBUNTU Server 16,04...
thebridge1.09 and 1.06 .disconnect crash