[Cppunit-devel] Some Questions

[Michel A. <Arm...@si...>]

Hi all.

Since the last time I had a look at the CppUnit project (v1.6.2), very much
has changed. Therefore I had a look at the sources this weekend. While
looking through the code, some questions came to my mind. I hope you can
help me out here:

1. CppUnit::Test
Why are the find-related methods not const? Shouldn't they? I feel const
find-methods are somewhat more intuitive, aren't they?

2. CppUnit::TestDecorator
This class doesn't delegate _all_ the methods. IMHO, in order to have a
completely transparent Decorator, it really should delegate all methods.
What do you think of this?

3. CppUnit::TestCase
Maybe we can enhance the run() method, so that it can also properly (with
SourceLine information) catch failures in both setUp() and tearDown()?

4. CppUnit::TestSuite
There is an unused m_name in this class (CppUnit::TestComposite already
defines this member; and actually uses it ;-)). Let's remove that unused
member?

5. CppUnit::TestRunner
Neither CppUnit::TextUi::TestRunner nor the MFC-based TestRunner reuses the
generic TestRunner in some way. Is that intended? Or are there some
refactorings pending? Just wondering...


I could do (2.) - (4.) my own and submit the changes; I just don't know how
to best submit these changes. (I don't have cvs-access here :-(.)

Regards

Armin