Re: [Cppunit-devel] CppUnit 1.7.10 tar ball

[Robert W. <ro...@po...>]

Hi!

Seems to be almost fine under Linux for me, too.

During installation I get these messages:
$ autoconf
You should update your `aclocal.m4' by running aclocal.
And later:
$ make install
[...]
/usr/bin/install: cannot create regular file 
`/usr/local/share/cppunit/html/html/index.html': No such file or 
directory
make[2]: *** [install-htmlDATA] Error 1
That's one "html" too much?

On using the deprecated TextTestRunner.h the preprocessor could not find
the include file, I changed in include/cppunit/TextTestRunner.h this
line
#include <cppunitui/text/TestRunner.h> 
to
#include <../cppunitui/text/TestRunner.h>

Documentation is somewhat better now. :-)

Anyway I still don't like the CppUnit::TextUi::TestRunner 
implementation. I don't like the call to runner.run with its boolean 
arguments for progress printing, waiting and summary printing. We do 
have listeners, if I do not add a listener I obvisiously do not want 
progress printing or waiting. If I do not add an outputter I 
obvisiously do not want a summary.
I think the runner should never ever add a listener on its own, 
especially not like in TestRunner.cpp in method runTest (Test*, bool) 
around line 131.
IMHO that's a good place to do some refactoring.

Another place for refactoring: have the CPPUNIT_ASSERT_EQUAL_MESSAGE 
macro take the message as its first argument as CPPUNIT_ASSERT_MESSAGE 
macro does. (Or make the message always the last argument, but make it 
always the same way.)


Robert