[Cppunit-devel] please ask

[Steve M. R. <ste...@vi...>]

Hi all,

We're going to need to start communicating, or there will be a lot of
toes begin stepped on.  Please: if something seems weird to you, ask
about it.  Don't assume.

I don't want to single people out, but here's what I see recently
checked in:

        * src/cppunit/TypeInfoHelper.cpp: removed #include <config.h>,
          cppunit/config.h was already included.

This is wrong.  <config.h> and <cppunit/config.h> are two different files.
Both must be included.

        * added include/cppunit/config.h with a default configuration for VC++ 6.0.

This is a bad idea.  This file is generated from config.h.in.  If you want
a default for VC++ 6.0, then include it with a different name, like
config.h.msvc6.  Then copy it or symlink it by hand.  You only need do
it once.

        * include/cppunit/.cvsignore: removed config.h from the list of ignored file.

This is a bad idea.  It is a generated file.  See previous.

Thanks,
-Steve



-- 
by Rocket to the Moon,
by Airplane to the Rocket,
by Taxi to the Airport,
by Frontdoor to the Taxi,
by throwing back the blanket and laying down the legs ...
- They Might Be Giants