RE: [Cppunit-devel] ch-ch-ch-changes ...

[Townsend, G. <gto...@sh...>]

> -----Original Message-----
> From: Steve M. Robbins
> Since there are already CU_-prefixed macros, I'm planning
> to use CU_assert unless I hear a better suggestion.  

I already mentioned it, but just to reiterate it here, I ask the question
whether macros shoudn't be all caps? 

Seems there is no coding standard for this project, and I wonder if it is
worth adopting one. I'm less concerned about which standard than whether
there is one. Of course one that seems to please the most people is best,
but that discussion could go on for a long time. Perhaps only those that
have cvs write access get a vote? That should shorten the discussion. The
Corelinux Consortium C++ Coding Standards is one possibility. It seems to be
one of the best that I've found.
http://corelinux.sourceforge.net/cppstnd.php

> I'm also planning to make a backwards-compatibility configure switch
> to enable the current "assert()" macro.  My natural inclination is to
> discourage the use of naked assert() by disabling it in the default
> build (i.e. if the switch is NOT given).  However, that's a bit
> obnoxious if CppUnit has a long history of using the naked assert().
> What is the general feeling about this?

My personal feeling is that since it conflicts with a standard C++ library
macro the original inclusion should be treated as a bug, and it should be
"fixed" (by making it NOT the default behavior). There absolutely needs to
be mention of it in release notes and in the header file. But I think it's
time to bite the bullet and make the change.  Reminds me of the XP process:
When code is found to be wrong, just fix it. make whatever adjustments are
necessary, and move on. Never to be bothered by that ugliness again.

Sure, there should be a way to turn the switch on at a project level, but
that is a small change to a makefile after discovering that assert() is
undefined. And hopefully the release notes are read first, and it's no
suprise. 

Steve, I certainly appreciate your contributions to the project. I haven't
had time to any actual code contribution yet, but I sure appreciate those
who are doing so.

Guy