cppunit-devel

RE: [Cppunit-devel] config-msvc6.h

[Bastiaan B. <bas...@li...>]

> -----Oorspronkelijk bericht-----
> Van: Baptiste Lepilleur [mailto:bl...@cl...]
> Verzonden: Monday, June 18, 2001 11:25 PM
> Aan: Cpp Unit Develpment Mailing List
> Onderwerp: [Cppunit-devel] config-msvc6.h
> 
> 
> Well, I tuned the config file for VC++. It works just fine !
> 
> In the file, I found the following piece of code:
> 
> /* Name of package */
> #ifndef CPPUNIT_PACKAGE 
> #define CPPUNIT_PACKAGE  "cppunit" 
> #endif
> 
> /* Version number of package */
> #ifndef CPPUNIT_VERSION 
> #define CPPUNIT_VERSION  "1.5.5" 
> #endif
> 
> Shouldn't those be common to any platforms (e.g. defined in 
> Portability.h)
>

They *are* common to all platforms, but they end up in
include/cppunit/config-auto.h through config/config.h. 
But of course we can get them in Portability.h as well, with help of a
Portability.h.in. I see if I have time to fix it tonight.
Not that we use these macro's anywhere :-)

Bastiaan

 
> Baptiste.
> ---
> Baptiste Lepilleur <gai...@fr...>   
> http://gaiacrtn.free.fr/index.html
> Author of The Text Reformatter, a tool for fanfiction readers 
> and writers.
> Language: English, French (Well, I'm French).
> 
> 
> 
> _______________________________________________
> Cppunit-devel mailing list
> Cpp...@li...
> http://lists.sourceforge.net/lists/listinfo/cppunit-devel
> 

Re: [Cppunit-devel] config-msvc6.h

[Steve M. R. <ste...@vi...>]

On Wed, Jun 20, 2001 at 01:19:11PM +0200, Bastiaan Bakker wrote:
> 
> 
> > -----Oorspronkelijk bericht-----
> > Van: Baptiste Lepilleur [mailto:bl...@cl...]
> > Verzonden: Monday, June 18, 2001 11:25 PM
> > Aan: Cpp Unit Develpment Mailing List
> > Onderwerp: [Cppunit-devel] config-msvc6.h
> > 
> > 
> > Well, I tuned the config file for VC++. It works just fine !
> > 
> > In the file, I found the following piece of code:
> > 
> > /* Name of package */
> > #ifndef CPPUNIT_PACKAGE 
> > #define CPPUNIT_PACKAGE  "cppunit" 
> > #endif
> > 
> > /* Version number of package */
> > #ifndef CPPUNIT_VERSION 
> > #define CPPUNIT_VERSION  "1.5.5" 
> > #endif
> > 
> > Shouldn't those be common to any platforms (e.g. defined in 
> > Portability.h)
> >
> 
> They *are* common to all platforms, but they end up in
> include/cppunit/config-auto.h through config/config.h. 
> But of course we can get them in Portability.h as well, with help of a
> Portability.h.in. I see if I have time to fix it tonight.

That's not going to help Baptiste!  

If we derive Portability.h from Portability.h.in, then no
Portability.h should be shipped (normally).  That brings us back to
the original problem that prompted Portability.h: either Portability.h
is shipped (possibly bad for autoconf?) or folks on non-autoconf
platforms need to copy Portability.h.in -> Portability.h and edit.
This brings no advantage to the current scheme that I can see.

> Not that we use these macro's anywhere :-)

Then we could simply ignore them!  Omit PACKAGE and VERSION from the
conf-xxx.h files entirely.

-S

-- 
by Rocket to the Moon,
by Airplane to the Rocket,
by Taxi to the Airport,
by Frontdoor to the Taxi,
by throwing back the blanket and laying down the legs ...
- They Might Be Giants

Re: [Cppunit-devel] config-msvc6.h

[Bastiaan B. <bas...@li...>]

"Steve M. Robbins" wrote:

> On Wed, Jun 20, 2001 at 01:19:11PM +0200, Bastiaan Bakker wrote:
> >
> >
> > > -----Oorspronkelijk bericht-----
> > > Van: Baptiste Lepilleur [mailto:bl...@cl...]
> > > Verzonden: Monday, June 18, 2001 11:25 PM
> > > Aan: Cpp Unit Develpment Mailing List
> > > Onderwerp: [Cppunit-devel] config-msvc6.h
> > >
> > >
> > > Well, I tuned the config file for VC++. It works just fine !
> > >
> > > In the file, I found the following piece of code:
> > >
> > > /* Name of package */
> > > #ifndef CPPUNIT_PACKAGE
> > > #define CPPUNIT_PACKAGE  "cppunit"
> > > #endif
> > >
> > > /* Version number of package */
> > > #ifndef CPPUNIT_VERSION
> > > #define CPPUNIT_VERSION  "1.5.5"
> > > #endif
> > >
> > > Shouldn't those be common to any platforms (e.g. defined in
> > > Portability.h)
> > >
> >
> > They *are* common to all platforms, but they end up in
> > include/cppunit/config-auto.h through config/config.h.
> > But of course we can get them in Portability.h as well, with help of a
> > Portability.h.in. I see if I have time to fix it tonight.
>
> That's not going to help Baptiste!
>
> If we derive Portability.h from Portability.h.in, then no
> Portability.h should be shipped (normally).  That brings us back to
> the original problem that prompted Portability.h: either Portability.h
> is shipped (possibly bad for autoconf?) or folks on non-autoconf
> platforms need to copy Portability.h.in -> Portability.h and edit.
> This brings no advantage to the current scheme that I can see.
>

This is not the same as theo original problem, because both symbols have
identical values for all platforms.
But I see having a Portabilitity.h.in and shipping Portability.h is
confusing. I'll leave it as is.

>
> > Not that we use these macro's anywhere :-)
>
> Then we could simply ignore them!  Omit PACKAGE and VERSION from the
> conf-xxx.h files entirely.

Yeah, let's ignore them. I'll start now... :-)

Bastiaan