Quoting "Summerwill, Bob" <BSu...@eu...>:
>
> I've just had a quick scan through CppUnit 1.6.0, and found these
> duplicated
> #includes. The <string> ones are due to addition of a <string> #include
> in
> Portability.h, making the other ones unnecessary.
Shoudln't that <string> only be included if you don't have
CPPUNIT_HAVE_SSTREAM anyway ?
Wouldn't it be better to move the declaration of OStringStream in its one
header (include/cppunit/portability, include/cppunit/tools ?), and includes it
only where it is used ?
Baptiste.
> Source file Duplicated include
> ----------- ------------------
> extensions/HelperMacros.h string
> extensions/TestFactoryRegistry.h string
> extensions/TestSuiteBuilder.h
> cppunit/extensions/TypeInfoHelper.h
> TestAssert.h string
> TestCase.cpp cppunit/Exception.h
> TestCase.h string
> TestSuite.h string
> TypeInfoHelper.cpp string
>
>
>
> Cheers,
> Bob
>
> _______________________________________________
> Cppunit-devel mailing list
> Cpp...@li...
> https://lists.sourceforge.net/lists/listinfo/cppunit-devel
>
---
Baptiste Lepilleur <gai...@fr...>
http://gaiacrtn.free.fr/index.html
Language: English, French
|
