cppunit-devel

[Cppunit-devel] please ask

[Steve M. R. <ste...@vi...>]

Hi all,

We're going to need to start communicating, or there will be a lot of
toes begin stepped on.  Please: if something seems weird to you, ask
about it.  Don't assume.

I don't want to single people out, but here's what I see recently
checked in:

        * src/cppunit/TypeInfoHelper.cpp: removed #include <config.h>,
          cppunit/config.h was already included.

This is wrong.  <config.h> and <cppunit/config.h> are two different files.
Both must be included.

        * added include/cppunit/config.h with a default configuration for VC++ 6.0.

This is a bad idea.  This file is generated from config.h.in.  If you want
a default for VC++ 6.0, then include it with a different name, like
config.h.msvc6.  Then copy it or symlink it by hand.  You only need do
it once.

        * include/cppunit/.cvsignore: removed config.h from the list of ignored file.

This is a bad idea.  It is a generated file.  See previous.

Thanks,
-Steve



-- 
by Rocket to the Moon,
by Airplane to the Rocket,
by Taxi to the Airport,
by Frontdoor to the Taxi,
by throwing back the blanket and laying down the legs ...
- They Might Be Giants

Re: [Cppunit-devel] please ask

[Baptiste L. <bl...@cl...>]

----- Original Message -----
From: "Steve M. Robbins" <ste...@vi...>
To: "CppUnit Development" <cpp...@li...>
Sent: Wednesday, June 06, 2001 12:26 AM
Subject: [Cppunit-devel] please ask


> Hi all,
>
> We're going to need to start communicating, or there will be a lot of
> toes begin stepped on.  Please: if something seems weird to you, ask
> about it.  Don't assume.
>
> I don't want to single people out, but here's what I see recently
> checked in:
>
>         * src/cppunit/TypeInfoHelper.cpp: removed #include <config.h>,
>           cppunit/config.h was already included.
>
> This is wrong.  <config.h> and <cppunit/config.h> are two different files.
> Both must be included.

    Sorry. All I can say is that I was pretty tired. I spent part of the
evening putting the windows side back into shape. I wanted to "get done with
it". I'll try to be more patient next time.

    Note that this mess would not have happen if those files had been
explained on the list ;-) . The point is I still don't know where or what is
supposed to be in that file (couldn't find any config.in for that one).

    Also the file is in the global include space (no directory prefix),
which is dangerous (you may include that file when you though you where
including another).

Baptiste.
---
Baptiste Lepilleur <gai...@fr...>   http://gaiacrtn.free.fr/index.html
Author of The Text Reformatter, a tool for fanfiction readers and writers.
Language: English, French (Well, I'm French).

Re: [Cppunit-devel] please ask

[Baptiste L. <bl...@cl...>]

----- Original Message -----
From: "Steve M. Robbins" <ste...@vi...>
To: "CppUnit Development" <cpp...@li...>
Sent: Wednesday, June 06, 2001 12:26 AM
Subject: [Cppunit-devel] please ask


> Hi all,
>
> We're going to need to start communicating, or there will be a lot of
> toes begin stepped on.  Please: if something seems weird to you, ask
> about it.  Don't assume.
>
> I don't want to single people out, but here's what I see recently
> checked in:
>
>         * src/cppunit/TypeInfoHelper.cpp: removed #include <config.h>,
>           cppunit/config.h was already included.
>
> This is wrong.  <config.h> and <cppunit/config.h> are two different files.
> Both must be included.

    Sorry. All I can say is that I was pretty tired. I spent part of the
evening putting the windows side back into shape. I wanted to "get done with
it". I'll try to be more patient next time and take the time to post an
mail.

    Note that this mess would not have happen if those files had been
explained on the list ;-) (yet, I still should have asked). The point is I
still don't know where or what is supposed to be in that file (couldn't find
any config.in for that one).

    Baptiste.
---
Baptiste Lepilleur <gai...@fr...>   http://gaiacrtn.free.fr/index.html
Author of The Text Reformatter, a tool for fanfiction readers and writers.
Language: English, French (Well, I'm French).

Re: [Cppunit-devel] please ask

[Steve M. R. <ste...@vi...>]

On Thu, Jun 07, 2001 at 11:07:11PM +0200, Baptiste Lepilleur wrote:

>     Note that this mess would not have happen if those files had been
> explained on the list ;-) 

Touche.  Point taken.


> (yet, I still should have asked). The point is I
> still don't know where or what is supposed to be in that file (couldn't find
> any config.in for that one).

Oh.  That's odd.  I did commit include/cppunit/config.h.in.
Don't you see that file when you cvsup?

-S


-- 
by Rocket to the Moon,
by Airplane to the Rocket,
by Taxi to the Airport,
by Frontdoor to the Taxi,
by throwing back the blanket and laying down the legs ...
- They Might Be Giants

Re: [Cppunit-devel] please ask

[Baptiste L. <bl...@cl...>]

----- Original Message -----
From: "Steve M. Robbins" <ste...@vi...>
To: "CppUnit Development" <cpp...@li...>
Sent: Wednesday, June 06, 2001 12:26 AM
Subject: [Cppunit-devel] please ask


> Hi all,
>
> We're going to need to start communicating, or there will be a lot of
> toes begin stepped on.  Please: if something seems weird to you, ask
> about it.  Don't assume.
>
> I don't want to single people out, but here's what I see recently
> checked in:
>
>         * src/cppunit/TypeInfoHelper.cpp: removed #include <config.h>,
>           cppunit/config.h was already included.
>
> This is wrong.  <config.h> and <cppunit/config.h> are two different files.
> Both must be included.

    Sorry. All I can say is that I was pretty tired. I spent part of the
evening putting the windows side back into shape. I wanted to "get done with
it". I'll try to be more patient next time and take the time to post an
mail.

    Note that this mess would not have happen if those files had been
explained on the list ;-) (yet, I still should have asked). The point is I
still don't know where or what is supposed to be in that file (couldn't find
any config.in for that one).

    Baptiste.
---
Baptiste Lepilleur <gai...@fr...>   http://gaiacrtn.free.fr/index.html
Author of The Text Reformatter, a tool for fanfiction readers and writers.
Language: English, French (Well, I'm French).

Re: [Cppunit-devel] please ask

[Baptiste L. <gai...@fr...>]

Quoting Baptiste Lepilleur <bl...@cl...>:

Sorry about this double mail posting. I'm having trouble with my e-mail client. 
It's hanging up the modem after while sending mail. It's driving me nuts. I'll 
probably be changing of client in a few day... Try to bear with it until then.

Thanks,
Baptiste.

> ----- Original Message -----
> From: "Steve M. Robbins" <ste...@vi...>
> To: "CppUnit Development" <cpp...@li...>
> Sent: Wednesday, June 06, 2001 12:26 AM
> Subject: [Cppunit-devel] please ask
> 
> 
> > Hi all,
> >
> > We're going to need to start communicating, or there will be a lot
> of
> > toes begin stepped on.  Please: if something seems weird to you, ask
> > about it.  Don't assume.
> >
> > I don't want to single people out, but here's what I see recently
> > checked in:
> >
> >         * src/cppunit/TypeInfoHelper.cpp: removed #include
> <config.h>,
> >           cppunit/config.h was already included.
> >
> > This is wrong.  <config.h> and <cppunit/config.h> are two different
> files.
> > Both must be included.
> 
>     Sorry. All I can say is that I was pretty tired. I spent part of
> the
> evening putting the windows side back into shape. I wanted to "get done
> with
> it". I'll try to be more patient next time and take the time to post
> an
> mail.
> 
>     Note that this mess would not have happen if those files had been
> explained on the list ;-) (yet, I still should have asked). The point is
> I
> still don't know where or what is supposed to be in that file (couldn't
> find
> any config.in for that one).
> 
>     Baptiste.
> ---
> Baptiste Lepilleur <gai...@fr...>  
> http://gaiacrtn.free.fr/index.html
> Author of The Text Reformatter, a tool for fanfiction readers and
> writers.
> Language: English, French (Well, I'm French).
> 
> 
> 
> 
> 
> 
> _______________________________________________
> Cppunit-devel mailing list
> Cpp...@li...
> http://lists.sourceforge.net/lists/listinfo/cppunit-devel
> 



---
Baptiste Lepilleur <gai...@fr...>
http://gaiacrtn.free.fr/index.html
Language: English, French