cppunit-devel

[Cppunit-devel] New TextTestRunner and hierarchy example update

[Baptiste L. <bl...@cl...>]

I've added a TextTestRunner and updated the hierarchy example to use it.

Name of the test that was running has been removed from TextTestResult since
it was obfuscating the output.

I've also merged Steve M. Robbins patch to replace assertImplementation with
assert in hierarchy example.

Let me know how that works on Unix.

Baptiste.

---
Baptiste Lepilleur <gai...@fr...>   http://gaiacrtn.free.fr/index.html
Author of The Text Reformatter, a tool for fanfiction readers and writers.
Language: English, French (Well, I'm French).

Re: [Cppunit-devel] New TextTestRunner and hierarchy example update

[Steve M. R. <ste...@vi...>]

On Sat, May 19, 2001 at 01:44:50PM +0200, Baptiste Lepilleur wrote:
> I've added a TextTestRunner and updated the hierarchy example to use it.
> 
> Name of the test that was running has been removed from TextTestResult since
> it was obfuscating the output.

Um.  I think you'd better revisit this change.  

I wasn't completely happy with the old output, and one of my "TODO"
items was to fix it and propose a patch.

However, the new output is worse.  All I get is dots with no
terminating newline:

	steve@riemann{intersection}./test_segment 
	...steve@riemann{intersection}

Very ugly.  

Whether to print test names or just dots should probably be made an
option.  I liked having the names output.

 
> Let me know how that works on Unix.

Seems okay, but someone broke "make distcheck" by removing a file from the
directory without updating the corresponding Makefile.am.

-S

-- 
by Rocket to the Moon,
by Airplane to the Rocket,
by Taxi to the Airport,
by Frontdoor to the Taxi,
by throwing back the blanket and laying down the legs ...
- They Might Be Giants

Re: [Cppunit-devel] New TextTestRunner and hierarchy example update

[Baptiste L. <bl...@cl...>]

> Um.  I think you'd better revisit this change.
>
> I wasn't completely happy with the old output, and one of my "TODO"
> items was to fix it and propose a patch.
>
> However, the new output is worse.  All I get is dots with no
> terminating newline:
   No, that's the way it's supposed to be (for me at least). It is also the
way it was done in Michael Feather's version. To me it makes sense:

    The dots are a show progress. A 'F' is printed to show that a test has
failed (equivalent to our progress becoming red). When all tests are run,
you got a report showing what failed (error report need to be made more
readable).

  Having test name and dot with new line would keep the screen scrolling.
This would be hard to use when you have more than a few tests.

  When we run test with the GUI test runner, we don't know which test is
running. On the other hand when a failure occurs, the full report is added
to the failure list. I guess we could dump the failure as soon it occured.
Though, I'm not sure that would be useful since failures would be spread
over many page of text which would keep scrolling as the other tests run.

  Also printing takes time, when you refactor and code test first, you run
the test every few seconds. You don't care which tests are run, you only
want to you if they run. You made sure that the test you added is run by
making it fails the first time.

  If that's not te way you to it, could you give your use case and the
output you'd like to have ?

> Whether to print test names or just dots should probably be made an
> option.  I liked having the names output.
  That could be done by giving the instance of the testresult to use to the
testrunner. But I'm not sure how to manage the lifecycle of the test result
(run() may be called more than once but testresult only support one run).
Suggestions ?

> Seems okay, but someone broke "make distcheck" by removing a file from the
> directory without updating the corresponding Makefile.am.
   That would be me. I moved TypeInfoHolder.h from src to include. I knew
this need to be updated when adding strange file (dsp/dsw), but I though it
automatically retreived .cpp/.h (that would make sense to me). I fixed it.

>
> -S
>
> --
> by Rocket to the Moon,
> by Airplane to the Rocket,
> by Taxi to the Airport,
> by Frontdoor to the Taxi,
> by throwing back the blanket and laying down the legs ...
> - They Might Be Giants
>
>
> _______________________________________________
> Cppunit-devel mailing list
> Cpp...@li...
> http://lists.sourceforge.net/lists/listinfo/cppunit-devel
>

Re: [Cppunit-devel] New TextTestRunner and hierarchy example update

[Baptiste L. <bl...@cl...>]

> > Seems okay, but someone broke "make distcheck" by removing a file from
the
> > directory without updating the corresponding Makefile.am.
>    That would be me. I moved TypeInfoHolder.h from src to include. I knew
> this need to be updated when adding strange file (dsp/dsw), but I though
it
> automatically retreived .cpp/.h (that would make sense to me). I fixed it.
  Correction: Baastian fixed it before I could. Thanks Baastian.

    Baptiste.
---
Baptiste Lepilleur <gai...@fr...>   http://gaiacrtn.free.fr/index.html
Author of The Text Reformatter, a tool for fanfiction readers and writers.
Language: English, French (Well, I'm French).

Re: [Cppunit-devel] New TextTestRunner and hierarchy example update

[Steve M. R. <ste...@vi...>]

On Sun, May 20, 2001 at 11:54:07AM +0200, Baptiste Lepilleur wrote:
> > Um.  I think you'd better revisit this change.
> >
> > I wasn't completely happy with the old output, and one of my "TODO"
> > items was to fix it and propose a patch.
> >
> > However, the new output is worse.  All I get is dots with no
> > terminating newline:
>    No, that's the way it's supposed to be (for me at least). It is also the
> way it was done in Michael Feather's version. To me it makes sense:
> 
>     The dots are a show progress. A 'F' is printed to show that a test has
> failed (equivalent to our progress becoming red). When all tests are run,
> you got a report showing what failed (error report need to be made more
> readable).

Yes, sure.  This is one option for output, I agree.  I think there ought to
be a newline after all the dots, that's all.  As it stands now, if all the
tests succeed, no further output is produced.

I also think that some folks (well, me anyway) may want a more verbose
output style.  I'm not suggesting that the default change.  Just that one
has an option.  I'll have a look and suggest a patch, maybe sometime this
week.
 

> > Seems okay, but someone broke "make distcheck" by removing a file from the
> > directory without updating the corresponding Makefile.am.
>    That would be me. I moved TypeInfoHolder.h from src to include. I knew
> this need to be updated when adding strange file (dsp/dsw), but I though it
> automatically retreived .cpp/.h (that would make sense to me).

Nope.  The Makefile.am files are the master record of the files required to
build the project.  They must be manually edited for all changes.


-- 
by Rocket to the Moon,
by Airplane to the Rocket,
by Taxi to the Airport,
by Frontdoor to the Taxi,
by throwing back the blanket and laying down the legs ...
- They Might Be Giants