cppunit-devel

[Cppunit-devel] Change done...

[Baptiste L. <bl...@cl...>]

Well, I finally comitted the thing. I checkout the project and it compiled
fine, so everything should be there (a lot of files have been added).

You should have exactly 80 unit tests running in cppunittests, and one
failing among those (that means 79 passing). If you don't, I somehow messed
up while updating the make file (and I probably forgot to update the
ChangeLog for that test too).

I'd like if someone could check the failing test case. It's
ExceptionTest::testAssignment(). I tried to find what's wrong, but I just
don't get it.

Here is what we should try to do the next time we make some change to
CppUnit:
- look over the unit test for the class
- if you have an hard time figuring out what a test did, rename it! (and
make sure to make it fail to see if it is still run)
- add a test for the new feature or to demonstrate the bug that is being
fixed

This should let us have a got test suite over time... To bad this can't be
applied for portability fix :-(.

Note that the code could use some refactoring. Many test that run TestCase
have an m_result instance and a checkResult() method...

There is a remaing unit test for NotEqualException to write, and use that
exception with the assertEquals().

Have fun,
Baptiste.
---
Baptiste Lepilleur <gai...@fr...>   http://gaiacrtn.free.fr/index.html
Author of The Text Reformatter, a tool for fanfiction readers and writers.
Language: English, French (Well, I'm French).

Re: [Cppunit-devel] Change done...

[Steve M. R. <ste...@vi...>]

On Mon, Jun 11, 2001 at 10:25:46PM +0200, Baptiste Lepilleur wrote:
> Well, I finally comitted the thing. I checkout the project and it compiled
> fine, so everything should be there (a lot of files have been added).

After some fine-tuning, I got it compiled under unix, with one
exception.


> You should have exactly 80 unit tests running in cppunittests, 

I couldn't get examples/cppunit/OrthodoxTest.cpp to compile, and
I couldn't figure out how to fix it.  Specifically, I don't understand
what is intended by all the "operator !()" functions.  They are
declared to return an object of class "Value", but in each case
the return statement is computing an integer.

After omitting OrthodoxTest, I got 72 tests which all passed.


-S


-- 
by Rocket to the Moon,
by Airplane to the Rocket,
by Taxi to the Airport,
by Frontdoor to the Taxi,
by throwing back the blanket and laying down the legs ...
- They Might Be Giants

Re: [Cppunit-devel] Change done...

[Baptiste L. <bl...@cl...>]

----- Original Message -----
From: "Steve M. Robbins" <ste...@vi...>
To: <cpp...@li...>
Sent: Tuesday, June 12, 2001 12:09 AM
Subject: Re: [Cppunit-devel] Change done...


> On Mon, Jun 11, 2001 at 10:25:46PM +0200, Baptiste Lepilleur wrote:
> > Well, I finally comitted the thing. I checkout the project and it
compiled
> > fine, so everything should be there (a lot of files have been added).
>
> After some fine-tuning, I got it compiled under unix, with one
> exception.
>
>
> > You should have exactly 80 unit tests running in cppunittests,
>
> I couldn't get examples/cppunit/OrthodoxTest.cpp to compile, and
> I couldn't figure out how to fix it.  Specifically, I don't understand
> what is intended by all the "operator !()" functions.  They are
> declared to return an object of class "Value", but in each case
> the return statement is computing an integer.
    It use the implicit constructor of Value which take an integer.

    I had an hard time thinking for a ! operator, and that probably reflect.

>
> After omitting OrthodoxTest, I got 72 tests which all passed.
>
>
> -S
---
Baptiste Lepilleur <gai...@fr...>   http://gaiacrtn.free.fr/index.html
Author of The Text Reformatter, a tool for fanfiction readers and writers.
Language: English, French (Well, I'm French).

Re: [Cppunit-devel] Change done...

[Baptiste L. <bl...@cl...>]

----- Original Message -----
From: "Steve M. Robbins" <ste...@vi...>
To: <cpp...@li...>
Sent: Tuesday, June 12, 2001 12:09 AM
Subject: Re: [Cppunit-devel] Change done...


> On Mon, Jun 11, 2001 at 10:25:46PM +0200, Baptiste Lepilleur wrote:
> > Well, I finally comitted the thing. I checkout the project and it
compiled
> > fine, so everything should be there (a lot of files have been added).
>
> After some fine-tuning, I got it compiled under unix, with one
> exception.
>
>
> > You should have exactly 80 unit tests running in cppunittests,
>
> I couldn't get examples/cppunit/OrthodoxTest.cpp to compile, and
> I couldn't figure out how to fix it.  Specifically, I don't understand
> what is intended by all the "operator !()" functions.  They are
> declared to return an object of class "Value", but in each case
> the return statement is computing an integer.
>
> After omitting OrthodoxTest, I got 72 tests which all passed.
    There is one missing. You should have 73 tests.

With this morning update (NotEqualException/assertEquals), you should have
(with OrthodoxTest disabled):

Run:  77   Failures: 1   Errors: 0
There was 1 failure:
1) test: ExceptionTest.testAssignment line: 103
g:\prg\vc\lib\cppunit\examples\c
ppunittest\exceptiontest.cpp
expected: message
but was:  Unknown exception

>
>
> -S
>
>
> --
> by Rocket to the Moon,
> by Airplane to the Rocket,
> by Taxi to the Airport,
> by Frontdoor to the Taxi,
> by throwing back the blanket and laying down the legs ...
> - They Might Be Giants
>
>
> _______________________________________________
> Cppunit-devel mailing list
> Cpp...@li...
> http://lists.sourceforge.net/lists/listinfo/cppunit-devel
>

[Cppunit-devel] examples/cppunittest

[Steve M. R. <ste...@vi...>]

Hi Baptiste,

I finally got around to looking at the cppunit testsuite again.


On Tue, Jun 12, 2001 at 09:27:15AM +0200, Baptiste Lepilleur wrote:
> ----- Original Message -----
> From: "Steve M. Robbins" <ste...@vi...>
> To: <cpp...@li...>
> Sent: Tuesday, June 12, 2001 12:09 AM
> Subject: Re: [Cppunit-devel] Change done...
> 
> 
> > On Mon, Jun 11, 2001 at 10:25:46PM +0200, Baptiste Lepilleur wrote:
> > > Well, I finally comitted the thing. I checkout the project and it
> compiled
> > > fine, so everything should be there (a lot of files have been added).
> >
> > After some fine-tuning, I got it compiled under unix, with one
> > exception.
> >
> >
> > > You should have exactly 80 unit tests running in cppunittests,
> >
> > I couldn't get examples/cppunit/OrthodoxTest.cpp to compile, and
> > I couldn't figure out how to fix it.  Specifically, I don't understand
> > what is intended by all the "operator !()" functions.  They are
> > declared to return an object of class "Value", but in each case
> > the return statement is computing an integer.

The problem turns out to be simply that two operator== methods were
not declared const.  Now it compiles and runs on linux.


> > After omitting OrthodoxTest, I got 72 tests which all passed.
>     There is one missing. You should have 73 tests.
> 
> With this morning update (NotEqualException/assertEquals), you should have
> (with OrthodoxTest disabled):
> 
> Run:  77   Failures: 1   Errors: 0
> There was 1 failure:
> 1) test: ExceptionTest.testAssignment line: 103
> g:\prg\vc\lib\cppunit\examples\c
> ppunittest\exceptiontest.cpp
> expected: message
> but was:  Unknown exception

When I run it now, I see 83 tests that all succeed.  I get no output
(other than dots).  Is that what you expect?


-- 
by Rocket to the Moon,
by Airplane to the Rocket,
by Taxi to the Airport,
by Frontdoor to the Taxi,
by throwing back the blanket and laying down the legs ...
- They Might Be Giants

Re: [Cppunit-devel] Change done...

[Baptiste L. <bl...@cl...>]

----- Original Message ----- 
From: "Steve M. Robbins" <ste...@vi...>
To: <cpp...@li...>
Sent: Tuesday, June 12, 2001 12:09 AM
Subject: Re: [Cppunit-devel] Change done...


> I couldn't get examples/cppunit/OrthodoxTest.cpp to compile, and
> I couldn't figure out how to fix it.  Specifically, I don't understand
> what is intended by all the "operator !()" functions.  They are
> declared to return an object of class "Value", but in each case
> the return statement is computing an integer.
    I added explicit construction to operator !. It might help.

    Baptiste.
---
Baptiste Lepilleur <gai...@fr...>   http://gaiacrtn.free.fr/index.html
Author of The Text Reformatter, a tool for fanfiction readers and writers.
Language: English, French (Well, I'm French).