The test runner used to crash when you removed a test that was in the most recently used list.
I added a line to TestRunnerDlg::updateHistoryCombo()
{...
if(test) ///I added
getHistoryCombo()->AddString( test->getName().c_str() );
...
}
and
void
TestRunnerModel::saveSettings()
{...
if(test) ///I added
saveHistoryEntry( idx, test->getName() );
...
}
It will not crash when I remove a testsuit.
Did it fix a bug?
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Yes, this has already been reported as bug 424320.
It is fixed in the current CVS tree. Your fix works, but I did it the other way: when a test is removed, it will not be added to the history list the next time you run TestRunner.
You can download the last version of TestRunnerModel.cpp using the CVS web browser.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
The test runner used to crash when you removed a test that was in the most recently used list.
I added a line to TestRunnerDlg::updateHistoryCombo()
{...
if(test) ///I added
getHistoryCombo()->AddString( test->getName().c_str() );
...
}
and
void
TestRunnerModel::saveSettings()
{...
if(test) ///I added
saveHistoryEntry( idx, test->getName() );
...
}
It will not crash when I remove a testsuit.
Did it fix a bug?
Yes, this has already been reported as bug 424320.
It is fixed in the current CVS tree. Your fix works, but I did it the other way: when a test is removed, it will not be added to the history list the next time you run TestRunner.
You can download the last version of TestRunnerModel.cpp using the CVS web browser.