|
From: Andre B. <and...@gm...> - 2002-12-13 22:13:35
|
I started getting into the sources, but I'm still not usefull for the
project :-(
i think it will take some time to get all the ideas. However I started
to play arround with
this Mutator concept and tried to implement this ToDo Item "Adding a
variable declaration in
if/while statement" ... not to make this for the public, but this is
something I can check against
later on, when you Baptiste have checked your sources in.
I got something working, but well, I'm not sure if this is ok and
there's a question:
The introduction of a new nodetype for the conditions makes some of the
tests failing, so how is this situation
handled ? Is it ok than to change the tests, too - since the assertion
only reports the new ast-node-type not
beeing expected.
Another thing is the MaxLODMutator ... In the beginning I stumbled
accross two things:
- the methods "mutate" and "doMutate" sound like the same action and
take the same parameters but they
do completely different things ... I would suggest some better naming
here ... maybe doMutate is just "doMultipleMutate" ?
- this MaxLODMutatorVisitor, what about that class, is this really needed ?
As I understand this class is only used to be instanciated in each
recursion of the mutation operation.
Is there anything I can't see ? The use of this class confused me
a little bit. With this class the recursion comes
Invisible for a person reading the source.... Just my opinion.
I'll next go into these Scope things -
and in parallel i'm still collecting the useful infos from the forum and
the mailing list.
See you later,
Andre
|