[Cpptool-develop] SourceBuilder::add3

[Sven R. <rei...@ma...>]

Recently, Baptiste wrote that he was unhappy with the name of this method. 
I agree with him insofar as it is not clear at all from the name what this 
method is supposed to do.

Inspecting the source code, it becomes clear that it does the following: 
It calls add three times, where the 2nd call is a keyed one (i.e., the 
object stores the range under some name). 

I don't see the advantage of combining these 3 calls into one. Thus, IMO 
the best way to deal with this name is to inline the method. We would have 
3 method calls instead of one, but it becomes clearer what the code does. 
I would also rename the keyed version of SourceBuilder::add to something 
like addKeyed or addAndRemember.

I would have gone ahead and done it, but I'd like to hear the reasons for 
introducing this method in the first place.

Any comments?

Sven.

BTW, is there anybody on this list except for Baptiste and me?

-- 
Sven Reichard
Dept. of Math. Sci.
University of Delaware
rei...@ma...