From: Sven R. <rei...@ma...> - 2002-11-27 19:59:56
|
On Wed, 27 Nov 2002, Baptiste Lepilleur wrote: > I added the files to the project. > > On the other, during the refactoring, you introduced a bug. How did you > manage to get past the ScopeGeneratorTest::testVariableDeclScope test ? > > I fixed the bug. In ScopeGenerator::visitNode(), canSkip() must be called > after the scope generation as some node may not need to visit any children > or properties, but may generate a scope (variable-decl for instance). Hmm... everything passed here. The only explanation I have is that ScopeGeneratorTest hasn't been added to the Makefile... I'll check that when I come home. > > Don't forget to also include astdump in your refactoring (the new visitor > header needed to be included). I'll do that. I have neglected that subdirectory for a while now. > Well, everything is working fine now. > Baptiste. > > -- Sven Reichard Dept. of Math. Sci. University of Delaware rei...@ma... |