From: Sven R. <rei...@ma...> - 2002-10-29 15:52:52
|
On Tue, 29 Oct 2002, Baptiste Lepilleur wrote: > > The class that need the most tests is VariableDeclMutator. It's non trivial > and not so easy to test. All other class are fairly simple and can be > tested/fixed in a few minutes... Ok, I'll look into that. > I did it the 'simplest way that could possibly work', in this case, the > refactoring creates a list of ReplaceTextTransform which are applied on the > TextDocument. There is no need for an AST rewritter at the current time. In > fact I don't have a clue on how to write one. There is a lot of issues > raised by this (which part of the AST did change, how to deal with spacing, > how to represent the AST transform...) You're right. I went ahead of myself. However, I didn't see exactly what was going on. One reason I tried to insist on more tests was also that they can serve as some kind of documentation; so far you are the only one who really understands the code. I don't mean to say that it is hard to read, it just will take some time and effort from my side. Sven. > Baptiste. |