Re: [Cpptool-develop] test & refactoring (was: checkout)

[Baptiste L. <gai...@fr...>]

----- Original Message -----
From: "Sven Reichard" <rei...@ma...>
To: "CppTool Mailing List" <Cpp...@li...>
Sent: Monday, October 28, 2002 10:48 PM
Subject: Re: [Cpptool-develop] checkout


> Ok, I see your point. However, I believe in the philosophy of "If it's not
> tested, consider it broken". So, unless you have anything else for me to
> do, I will continue to write unit tests. Our project tester, Victor,
> doesn't appear to be subscribed to this list. There are plenty of untested
> classes in the rftaparser directory, which you probably consider trivial,
> but which I still need to understand.

The class that need the most tests is VariableDeclMutator. It's non trivial
and not so easy to test. All other class are fairly simple and can be
tested/fixed in a few minutes...

> A conceptual question: Does the refactoring engine directly rewrite the
> sources, or does it change the AST representation, which then writes the
> sources independently? This is not an issue yet, but the latter strategy
> would help avoiding re-parsing for each refactoring step.

I did it the 'simplest way that could possibly work', in this case, the
refactoring creates a list of ReplaceTextTransform which are applied on the
TextDocument. There is no need for an AST rewritter at the current time. In
fact I don't have a clue on how to write one. There is a lot of issues
raised by this (which part of the AST did change, how to deal with spacing,
how to represent the AST transform...)

Baptiste.
>
> --
> Sven Reichard
> Dept. of Math. Sci.
> University of Delaware
> rei...@ma...