----- Original Message -----
From: "Sven Reichard" <rei...@ma...>
To: "CppTool Mailing List" <Cpp...@li...>
Sent: Wednesday, December 04, 2002 5:32 PM
Subject: [Cpptool-develop] SourceBuilder::add3
> Recently, Baptiste wrote that he was unhappy with the name of this method.
> I agree with him insofar as it is not clear at all from the name what this
> method is supposed to do.
>
> Inspecting the source code, it becomes clear that it does the following:
> It calls add three times, where the 2nd call is a keyed one (i.e., the
> object stores the range under some name).
>
> I don't see the advantage of combining these 3 calls into one. Thus, IMO
> the best way to deal with this name is to inline the method. We would have
> 3 method calls instead of one, but it becomes clearer what the code does.
> I would also rename the keyed version of SourceBuilder::add to something
> like addKeyed or addAndRemember.
Lisibility of user code. Source code build that's way is already difficult
to read, if we were to split simple statement on multiple lines, it would
become near impossible.
For instance (renaming add3 to addKeyingMid):
builder_->addKeyingMid( " if ( ", "x", " > 3 )", "var1.3" );
builder_->add( " {" );
builder_->addKeyingMid( " int ", "x", " = ", "var2.1" );
builder_->addKeyingMid( "", "x", ",", "var2.4" );
builder_->addKeyingMid( "", "y", "=", "var3.1" );
builder_->addKeyingMid( "", "x", ";", "var2.2" );
builder_->addKeyingMid( " ", "y", ";", "var3.2" );
builder_->addKeyingMid( " ", "x", ";", "var2.3" );
builder_->add( " }" );
Is just a lot more readable and compact than:
builder_->add( " if ( " );
builder_->addKeyed( "x", "var1.3" );
builder_->add( " > 3 )" );
builder_->add( " {" );
builder_->add( " int " );
builder_->addKeyed( "x", "var2.1" );
builder_->add( " = " );
builder_->addKeyed( "x", "var2.4" );
builder_->add( "," );
builder_->addKeyed( "y", "var3.1" );
builder_->add( "=" );
builder_->addKeyed( "x", "var2.2" );
builder_->add( ";" );
builder_->add( " " );
builder_->addKeyed( "y", "var3.2" );
builder_->add( ";" );
builder_->add( " " );
builder_->addKeyed( "x", "var2.3" );
builder_->add( ";" );
builder_->add( " }" );
A lot of C++ structure seems to be expressible in three parts when writing
keyed text for test. This includes variable declarations,
if/for/while/switch conditions, and some expressions.
addKeyingMid() keeps the code compact and somewhat readable. I can't see
Inlining as a solution. Renaming is the best solution I see for now;
providing a similar facility in some other but practical form is another
one.
For now, I suggest to simply rename add(string, string) to addKeyed() and
add3() to addKeyingMid().
Baptiste.
>
> I would have gone ahead and done it, but I'd like to hear the reasons for
> introducing this method in the first place.
>
> Any comments?
>
> Sven.
>
> BTW, is there anybody on this list except for Baptiste and me?
>
> --
> Sven Reichard
> Dept. of Math. Sci.
> University of Delaware
> rei...@ma...
|
