cpptool-develop

[Cpptool-develop] files added

[Sven R. <rei...@ma...>]

Baptiste,

I continued working on the visitor classes. I extracted them to their own 
files, so you will have to edit the dsp/dsw files.

Sven.

-- 
Sven Reichard
Dept. of Math. Sci.
University of Delaware
rei...@ma...

Re: [Cpptool-develop] files added

[Baptiste L. <gai...@fr...>]

I added the files to the project.

On the other, during the refactoring, you introduced a bug. How did you
manage to get past the ScopeGeneratorTest::testVariableDeclScope test ?

I fixed the bug. In ScopeGenerator::visitNode(), canSkip() must be called
after the scope generation as some node may not need to visit any children
or properties, but may generate a scope (variable-decl for instance).

Don't forget to also include astdump in your refactoring (the new visitor
header needed to be included).

Well, everything is working fine now.
Baptiste.


----- Original Message -----
From: "Sven Reichard" <rei...@ma...>
To: "CppTool Mailing List" <Cpp...@li...>
Sent: Wednesday, November 27, 2002 6:36 PM
Subject: [Cpptool-develop] files added


> Baptiste,
>
> I continued working on the visitor classes. I extracted them to their own
> files, so you will have to edit the dsp/dsw files.
>
> Sven.
>
> --
> Sven Reichard
> Dept. of Math. Sci.
> University of Delaware
> rei...@ma...
>
>
>
> -------------------------------------------------------
> This SF.net email is sponsored by: Get the new Palm Tungsten T
> handheld. Power & Color in a compact size!
> http://ads.sourceforge.net/cgi-bin/redirect.pl?palm0002en
> _______________________________________________
> Cpptool-develop mailing list
> Cpp...@li...
> https://lists.sourceforge.net/lists/listinfo/cpptool-develop
>
>

Re: [Cpptool-develop] files added

[Sven R. <rei...@ma...>]

On Wed, 27 Nov 2002, Baptiste Lepilleur wrote:

> I added the files to the project.
> 
> On the other, during the refactoring, you introduced a bug. How did you
> manage to get past the ScopeGeneratorTest::testVariableDeclScope test ?
> 
> I fixed the bug. In ScopeGenerator::visitNode(), canSkip() must be called
> after the scope generation as some node may not need to visit any children
> or properties, but may generate a scope (variable-decl for instance).

Hmm... everything passed here. The only explanation I have is that 
ScopeGeneratorTest hasn't been added to the Makefile... I'll check that 
when I come home.

> 
> Don't forget to also include astdump in your refactoring (the new visitor
> header needed to be included).

I'll do that. I have neglected that subdirectory for a while now.
 
> Well, everything is working fine now.
> Baptiste.
> 
> 

-- 
Sven Reichard
Dept. of Math. Sci.
University of Delaware
rei...@ma...

Re: [Cpptool-develop] files added

[Baptiste L. <gai...@fr...>]

----- Original Message -----
From: "Sven Reichard" <rei...@ma...>
To: "CppTool Mailing List" <Cpp...@li...>
Sent: Wednesday, November 27, 2002 8:59 PM
Subject: Re: [Cpptool-develop] files added


> On Wed, 27 Nov 2002, Baptiste Lepilleur wrote:
>
> > I added the files to the project.
> >
> > On the other, during the refactoring, you introduced a bug. How did you
> > manage to get past the ScopeGeneratorTest::testVariableDeclScope test ?
> >
> > I fixed the bug. In ScopeGenerator::visitNode(), canSkip() must be
called
> > after the scope generation as some node may not need to visit any
children
> > or properties, but may generate a scope (variable-decl for instance).
>
> Hmm... everything passed here. The only explanation I have is that
> ScopeGeneratorTest hasn't been added to the Makefile... I'll check that
> when I come home.

Yup, I just saw that. I added some other missing files as well.

Baptiste.