On Fri, Aug 19, 2016 at 12:06 PM, Marcel Hellwig <ke...@co...> wrote:
> Hi Artyom,
>
> I see some points in the code where variadic tempaltes[0] would make sense, e.g. url_dispatcher:assign.
> There are some thing I notice in the current trunk version. There is a thing called `generic_handler` and I think the purpose is to replace the old handler* typedefs, right? Why not use something like `template <class... Strings> typedef booster::function<void(Strings...)> generic_handler;` ? It would fit all needings and has always the right number of arguments. You use it in the map function that are declared with v1_2, which is strange, because you drop pre-c++11 compiler, is that intended (I would really welcome it)?
> The same thing can be used in the url_mapper:map function, where you did not do such thing until now.
> The question is, should this framework go full c++11? Drop c++98 completly (hint: yes! :) ).
This is good question. However I'm not going to drop C++ 2003 support:
1. I don't want to break existing code for users that can't upgrade or
do not want to (for example rock stable Linux releases that do not
ship c++11 enable gcc by default)
2. Specific stuff like variadic templates is actually implementable in
terms of C++03 without problems (yes it takes much more code) but this
isn't what would require me to switch
3. I do want to make it more C++11 friendly - for example by adding
move constructors/assignments
There are lots of stuff that can be done by moving to C++11 but if you
do it, it also good to switch lots of other stuff to C++11 (like
booster::thread, booster::regex) but it can't be done fully.
To be honest I prefer to keep it C++03 compatible but with new
interfaces supporting C++11 like move constructors.
> Also, I would like to participate more, but I don't know really how. I made some patch requests in the past, but I don't like the sourceforge way.
> I would like to see CppCMS to become a more community-driven and not a single-person project like now. I really like to use it, but don't get me wrong,
> I want to become it even better and more popular. I don't know any framework like this.
>
You know I really need working hands that can write the code, create
unit-tests, improve the platform and more. But until now I got
very-very few serious contributions.
And when I get them I take them seriously. So it is one man project
because I'm a single person who actually does the job. Also I have
many people who talk about
contributions without actually doing any valuable stuff.
I have no problem giving the access to SF repo as long as I see some
effort, believe me that after several patches i can provide commit
rights to contributors
(subject to copyright agreements
http://cppcms.com/wikipp/en/page/cppcms_1x_coding_standards#Copyrights)
However I hadn't seen too many standing in line ;-)
> Keep up the good work and please don't forget to answer my questions ;)
>
> Regards,
> Marcel
>
Regards,
Artyom
>
>
> [0]: https://en.wikipedia.org/wiki/Variadic_template
>
> ------------------------------------------------------------------------------
> _______________________________________________
> Cppcms-users mailing list
> Cpp...@li...
> https://lists.sourceforge.net/lists/listinfo/cppcms-users
|