Re: [cpp-netlib-devel] Pion's HTTPParser

[Dean M. B. <mik...@gm...>]

Hi Alex,

On Dec 13, 2007 6:13 PM, Alex Ott <al...@gm...> wrote:
> Hello all
>
> On Dec 11, 2007 9:22 AM, Dean Michael Berris <mik...@gm...> wrote:
> > Hi Alex,
> >
> > On Dec 11, 2007 4:14 PM, Alex Ott <al...@gm...> wrote:
> > >
> > > i had looked into protocol/http/impl/request.hpp and had seen, that it
> > > include URI parser. i think, that it better to implement URI parser in
> > > their own namespace, as it could be used not only in http parsing, but
> > > also in other places.
> >
> > Yup, I agree. I intend to refactor those out later -- but that would
> > mean there would be tons of tests just to make sure that the parser is
> > correct. That sounds like a lot of work, but if you'd like to try that
> > out, please be my guest. :)
>
> Here is small patch, that could be useful - it should capture
> userinfo, that sometimes used in URI's.
> I'm thinking about rewriting URI part to complete matching to rfc 3986
>

Please write tests to cover this addition.

If you can, please write tests to make sure that the parsing is
compliant with the rfc as well.

Thank you very much.

-- 
Dean Michael C. Berris
Software Engineer, Friendster, Inc.
[http://cplusplus-soup.blogspot.com/]
[mik...@gm...]
[+63 928 7291459]
[+1 408 4049523]