Re: [cpp-netlib-devel] Some code already up in subversion

[Glyn M. <gly...@gm...>]

Dean,

On 20/05/07, Dean Michael Berris <mik...@gm...> wrote:

> I'm developing this using the Test Driven Development approach, where
> I write the tests first (in libs/network/test) then make the tests
> "run green" by adding new functionality and/or refactoring.


That's a good approach, I agree.  But I ran the tests immediately and they
didn't run.  I used gcc 4.1.2 and intel icc 9.1 on suse linux 10.2.  I was
able to run the tests by changing the following lines to:

network/message/wrappers/headers.hpp:35
return headers_wrapper<Tag>::_message.headers().equal_range(key)

network/message/wrappers/headers.hpp:39
return headers_wrapper<Tag>::_message.headers().count(key)

And I also replaced the local class "tags" in the first test case.

For the tests it might be better to include individual headers (e.g.
message.hpp instead of network.hpp).  Also, I'm a bit worried that the
header guards could potentially clash (for example, you have used
__NETWORK_HPP__ and I've seen that defined in other headers that I've come
across).  These are minor things, however.

How do you intend to structure the tests?  Will you test the different
layers that you have described distinctly?  Have you given any thought to
how to test between layers?

I have to say I'm new to boost development, should I update any changes
myself or do I have to pass them by you first?

Kind regards,
Glyn