From: Emre T. <emr...@gm...> - 2011-02-24 07:55:35
|
Hi Dean, On Feb 24, 2011, at 7:01 AM, Dean Michael Berris wrote: > Hi Emre, > > On Wed, Feb 23, 2011 at 6:22 AM, Emre Türkay <emr...@gm...> wrote: >> Hi folks, >> >> In file boost/network/protocol/http/server/sync_connection.http (in sync_connection::start), line 57, there is a call to Handler::log(string). >> 1. This conflicts with the documentation, where there is no hello_world::log() method implemented in the simple http server example. >> 2. Do we really need to keep it that way, i.e., we can make boost::system::system_error an extra argument to the handler function (like asio handlers). By this way, it would even be possible to implement a handler with a free standing function and pass the http::server a ptr to function instead of a functor, for simple cases. >> >> What you think? >> > > I like #2 -- do you have a pull request? :) No, I wanted to ask before diving in. I'm still reading the docs ;) I'll try if I can make it. > > -- > Dean Michael Berris > about.me/deanberris |