Re: [cpp-netlib-devel] Merge to master

[Steve H. <ste...@gm...>]

Dean Michael Berris <mikhailberis@...> writes:
...
> Is anybody able to check out the documentation and see if there are
> any glaring issues that need to be addressed?

The documentation is coming along well.  I'd like to see a little bit on
the client::request and client::response public API, particularly their
use on the async variants.

> Feedback would be greatly appreciated.

It's a very impressive library design, and more so given its
comprehensive use of Boost.  I particularly admire your diligence in
constructing the Concept checks.

Having read through recent discussions on Request and Response body
representations, I have to agree with others that a string type (or any
container which assumes contiguous storage) is unsuitable for production
use.  Of course, having body representations /constructible/ from
strings is desirable for the ease of use you are advocating, similar in
convenience to stringstream.

You may have already considered using the Boost.Iostreams Source concept
for the client::request body, and the Sink concept for the
client::response body.  I think that chunking, transfer-encoding,
multipart/form, and MIME layers would be much more manageable with the
Boost.Iostream Filter concept, too.

> Thanks and have a good day guys.

Thanks and best wishes to you.

/Steve Hartwell
YouSendIt.com