Re: [cpp-netlib-devel] Warning in

[Jeroen H. <vex...@gm...>]

Hi,

On Thu, Jan 21, 2010 at 17:57, Nelson, Erik - 2
<eri...@ba...> wrote:
> In boost/network/uri/http/uri_concept.hpp line 22, I get a warning about
> conversion from a 32-bit to 16-bit integer
>
> 'initializing' : conversion from 'boost::uint32_t' to 'boost::uint16_t',
> possible loss of data
>
> Here's the offending line
>
> uint16_t port_ = port(uri);
>
> I'm not sure if it matters (probably doesn't) but if the truncation is
> as designed we might consider making it explicit with a cast.
>
> Thanks
>
> Erik
>

It seems I missed two uint32_t's when moving to the uint16_t type for
ports, I've attached a trivial patch which should fix this. The
attached patch also updates the documentation and tests.

Jeroen