Re: [cpp-netlib-devel] url_encode bug

[Jeroen H. <vex...@gm...>]

Hi Dean,

On Sun, Jan 10, 2010 at 15:44, Dean Michael Berris
<mik...@gm...> wrote:
> Hi Jeroen,
>
> On Sun, Jan 10, 2010 at 6:52 AM, Jeroen Habraken <vex...@gm...> wrote:
>> Hi,
>>
>> A friend of mine just ran into a corner-case bug in the url_encode
>> function in "boost/network/protocol/http/impl/message.ipp". In the
>> current 0.5-devel tree it's on line 82, 'sprintf(encode_buf+1, "%2X",
>> str[pos]);' to be specific. The format string there should be changed
>> to "%02X" to reflect the zero padding (instead of the default space
>> padding), as one-character letters such as '\n' are now encoded as '%
>> A' (space, A) instead of '%0A' (zero, A).
>>
>
> Thanks for the report. If you can fix in a patch that would be most helpful too.
>
> Actually this was ported in still from pion, and is somewhat
> "unsupported" yet. I'd prefer this to be re-implemented using
> Boost.Spirit's Karma.

I'd too love to see this re-implemented using Boost.Spirit's Karma.

>
> Let me file an issue in the cpp-netlib project so that we can track
> this properly.
>
> Have a good day and I hope to see patches for this soon too. ;)
>

Sure, I'll write one this evening, and attach it to the issue, it's
rather trivial anyway.

Jeroen