From: K. G. <kim...@gm...> - 2008-10-13 06:46:29
|
Hi Glyn, On Sun, Oct 12, 2008 at 12:52, Glyn Matthews <gly...@gm...> wrote: > > I've taken a look, and the tests seem OK. It didn't compile on GCC because > you'd left all the typenames in, but I did a bit of refactoring to fix > this. I made it a template (basic_url) and provided a default typedef. > This is similar to the way we're using basic_message, so it's more > consistent. I think for basic_message and basic_url, it would eventually be > necessary to refactor the traits because they will have a lot in common. Yes, that was something I was thinking of as well, but I didn't want to duplicate the tags/traits. For a start, though, this looks good, then we can work towards unifying them. I continued trying to get the tags/traits in place, but I never managed to get it to work. I wasn't sure whether to base traits around boost::network::default_tags or uri::tags -- the latter requires that uri is defined, which I think creates a circular dependency between uri.hpp and traits/string.hpp. Thanks for helping, - Kim |