Re: [cpp-netlib-devel] [python] Getting HTTP Headers

[Allister L. S. <all...@gm...>]

Hi Kim,
I think it'd be better to parse the standard headers first in the handler
class (HttpTestHandler), to make it easier for people to write scripts for
various tests, and not have to duplicate code for the standard HTTP headers.
 Besides, we only use HTTP_ALL_HEADERS for custom headers.  We can then
write different CGI scripts for tests using different custom headers.  So
having both could be beneficial.

Also, I think it's better that we expose the command handles do_GET,
do_POST, do_DELETE, etc. (as was the case in revision 90 of
http_test_server.py) at the level of the HttpTestHandler class as we are
most likely to overload them in the future to fully comply with RFC 2616.

That said though, I would love to hear the thoughts of the others on this.

Cheers,
Allister

On Wed, Sep 10, 2008 at 4:42 PM, Kim Gräsman <kim...@gm...> wrote:

> Hi Allister,
>
> It wasn't quite as easy, but almost. I've committed a version that
> forwards all headers, newline-separated, as a string in
> HTTP_ALL_HEADERS.
>
> Not sure if it was a good idea, but I replaced all your named header
> handling with this simple, raw, forwarding. Maybe we should have both?
> Not sure if it makes sense, though.
>
> All tests seem to run anyway, at least on Windows.
>
> Thanks,
> - Kim
>