Re: [cpp-netlib-devel] localhost_tests failures

[K. G. <kim...@gm...>]

Hi Dean,

On Fri, Sep 5, 2008 at 11:27, Dean Michael Berris
<mik...@gm...> wrote:
>
> I was hasty in praising the patch... But the fact that you're copying
> code from Python (which I think is GPLed) and modifying it to be
> applied to a Boost Licensed project/file is going to raise some red
> flags.
>
> IANAL, but I think we cannot merge this based on licensing issues.

Yep, it didn't occur to me at the time, but when you mentioned the
word "license", it seemed like a risky thing.

Based on the Python license Divye posted, it looks pretty safe, but
what do I know?

> I think it's better you raise it with the Python developers mailing
> list and submit a patch there.

Yes, I think I will bounce it over there, just to see if I can move
this forward.

> That said, I don't think spending any more time in this unit test just
> to make it work in Windows where Python is broken isn't the best thing
> to do at the moment. The simplest thing (and most effective thing) to
> do is to mark it as an expected failure in Windows.

Sure, I agree. I just thought I had it canned :)

> As for better use of time, adding more tests would be nice -- for
> example, adding a test for making sure POST works through the CGI
> script, the permutations of the .post(...) API call.

This looks like something I could spend some time on.

> If you're up for it, refactoring the URI parser would be a nice thing
> to do too -- to move it from network/protocol/http/impl/request.hpp to
> a different file in network/utils/.

This looks like fun as well, we'll see if I can find some time to look
into it. I wouldn't want to claim it, though, so if anybody else is up
for it, feel free.

> I hope you understand that there are other more important things to
> fix than this single failing unit test where the cause of the failure
> is a third-party application we so happen to use for testing (which
> apparently doesn't have problems in other platforms).

Absolutely. Though I must admit that getting all tests to run on
Windows is a priority for me, as that's my base platform.

Cheers,
- Kim