Re: [cpp-netlib-devel] localhost_tests failures

[Dean M. B. <mik...@gm...>]

On Fri, Sep 5, 2008 at 4:03 PM, Kim Gräsman <kim...@gm...> wrote:
> Dean, Divye,
>
> On Fri, Sep 5, 2008 at 09:37, Dean Michael Berris
> <mik...@gm...> wrote:
>>
>> Divye, since this is your code, would you mind taking a look and
>> applying the patch and maybe committing if it's alright with you? I'm
>> guessing the change has to be under the Boost Software License as
>> well. ;-)
>
> I'm not sure if there could be any license issues, as I copied and
> modified two methods from the Python base lib.
>

I was hasty in praising the patch... But the fact that you're copying
code from Python (which I think is GPLed) and modifying it to be
applied to a Boost Licensed project/file is going to raise some red
flags.

IANAL, but I think we cannot merge this based on licensing issues.

> I'll see if I can vent this on some Python list as well, unless
> there's someone here involved in Python (this is the first time I see
> Python code :-/) that would care to carry it forward. It'd be nice if
> this could go in the main distro, unless there's something wrong with
> the approach.
>

I think it's better you raise it with the Python developers mailing
list and submit a patch there.

That said, I don't think spending any more time in this unit test just
to make it work in Windows where Python is broken isn't the best thing
to do at the moment. The simplest thing (and most effective thing) to
do is to mark it as an expected failure in Windows.

As for better use of time, adding more tests would be nice -- for
example, adding a test for making sure POST works through the CGI
script, the permutations of the .post(...) API call.

If you're up for it, refactoring the URI parser would be a nice thing
to do too -- to move it from network/protocol/http/impl/request.hpp to
a different file in network/utils/.

I hope you understand that there are other more important things to
fix than this single failing unit test where the cause of the failure
is a third-party application we so happen to use for testing (which
apparently doesn't have problems in other platforms).

Thanks, and I hope this helps.

-- 
Dean Michael C. Berris
Software Engineer, Friendster, Inc.