Re: [cpp-netlib-devel] localhost_tests failures

[Dean M. B. <mik...@gm...>]

On Wed, Sep 3, 2008 at 4:08 PM, Kim Gräsman <kim...@gm...> wrote:
>
>> The premise of the test is:
>> - when we request a file that has CRLF line endings, we get it with
>> CRLF line endings
>> - cpp-netlib will not fail because having CRLF line endings in the
>> body should be acceptable
>> - CRLF line endings are preserved when the body of an http::response
>> is retrieved.
>
> Ah, are the CRLF line endings the primary feature of this test?
>

Okay, a bit of history required I think...

In the first incarnation (very early implementation) of the
http::client, it performed a getline(stream, string) which stripped
the line endings from responses. So Divye implemented a test which
exposes this bug in the form of files with CRLF line endings.

> It hasn't occurred to me, but text_file_query probably implies
> something about the line endings...
>

Right, I think the name would was a little vague too now that I think
about it. ;-)

> Maybe both should be covered, e.g.
>
>  text_query_crlf_preserved
>  text_query_lf_preserved
>
> The first would have to be ignored on Windows, as there's no way of
> making that pass with the current Python implementation.
>

Maybe... But really, I think we shouldn't make too much of a case
regarding getting around Python especially since they won't be fixing
that bug and since we're only interested in making sure we *do* get
the CRLF's when they go through the wire without causing the client to
break.

> Are we getting closer? :)

I personally think just marking it an expected failure on Windows with
explicit documentation stating the rationale (citing the Python bug)
would be sufficient.

Although a test case where we have just LF's would be alright as well.

-- 
Dean Michael C. Berris
Software Engineer, Friendster, Inc.