From: K. G. <kim...@gm...> - 2008-09-03 08:08:28
|
Hi Dean, On Wed, Sep 3, 2008 at 09:28, Dean Michael Berris <mik...@gm...> wrote: > > We're not testing the serving of the file -- because that's Python's > domain, and we're not testing the Python server -- but rather we're > testing the reception of the file to make sure that *if* and *when* > the file contains CRLF line endings, that we catch it as is. Right. > The premise of the test is: > - when we request a file that has CRLF line endings, we get it with > CRLF line endings > - cpp-netlib will not fail because having CRLF line endings in the > body should be acceptable > - CRLF line endings are preserved when the body of an http::response > is retrieved. Ah, are the CRLF line endings the primary feature of this test? It hasn't occurred to me, but text_file_query probably implies something about the line endings... Maybe both should be covered, e.g. text_query_crlf_preserved text_query_lf_preserved The first would have to be ignored on Windows, as there's no way of making that pass with the current Python implementation. Are we getting closer? :) Thanks, - Kim |