Re: [cpp-netlib-devel] localhost_tests cleanup

[K. G. <kim...@gm...>]

Hi Divye,

On Wed, Sep 3, 2008 at 08:43, Divye Kapoor <div...@gm...> wrote:
>
> I tried extracting the ShellExecuteEx and Fork into a separate header file
> and creating the fixture but I was continually running into segmentation
> faults. So, I put it aside for a while. Thanks for the patch!

Oops--let's hope that doesn't show again! I haven't been able to run
the tests on Linux, so I've done my best to move the source as it was
into the new header.

> I think Dean's made a pretty good explanation of what I'm trying to convey.
> The file size test that fails on Windows actually passes on Linux because
> the linux version of the python library doesn't convert the CRLF to a single
> LF. Its a known bug in the Python library that causes the file size mismatch
> on windows. Although it helps to keep the tests clean, the text file
> transfer test is an expected failure on Windows. It would be better to mark
> this test as an expected failure in the test suite rather than making up for
> the shortcomings of the Python server.

As we've hashed out in other threads, I disagree. I think an expected
failure-test is pretty useless.

- Kim