From: K. G. <kim...@gm...> - 2008-09-03 07:17:35
|
Hi Divye, On Wed, Sep 3, 2008 at 08:50, Divye Kapoor <div...@gm...> wrote: > > On Wed, Sep 3, 2008 at 11:59 AM, Kim Gräsman <kim...@gm...> wrote: >> >> Wait... OK, I think I see what's happening: >> >> 1) test.xml always contains CRLF, even on Linux >> 2) On Linux, the Python server serves test.xml with CRLF endings intact >> 3) If we change test.xml to LF-only, we have worse test coverage for >> line ending independence >> >> Is that it? > > That's just it. :-) Cool, thanks :) I'm still not happy with having the test fail on Windows due to a known bug in a third party, but now I understand why converting line endings on test.xml can be problematic. I think my main concern is that marking the test as an expected failure makes it useless--if failure is expected, the only way it can demonstrate a change in behavior is if Python suddenly starts working. That said, if we're worried about line endings causing trouble, shouldn't we have targetted tests for that? Cheers, - Kim |