From: K. G. <kim...@gm...> - 2008-09-03 07:00:26
|
Hi Dean, On Wed, Sep 3, 2008 at 08:44, Dean Michael Berris <mik...@gm...> wrote: > >> I don't see how that's an improvement over saving test.xml with >> LF-only line endings, and get consistent test results...? I understood >> Divye's point to be that if we did that, we would mask something else. >> > > It's not about changing the test data to make sure the tests run, it's > more about making sure we get the correct data that we expect from the > HTTP Server -- and if I requested for a file that has CRLF line > endings in from the server, that I would get the exact same file if I > read it from disk in binary mode. The thing is, the server you're using cannot serve a file containing CRLF "for technical reasons" -- wouldn't it seem better to base the test off a file with LF only? That way you preserve the premise of the test, but change the details to compensate for the "technical reasons", so that the test is still valid. - Kim |