Re: [cpp-netlib-devel] localhost_tests failures

[K. G. <kim...@gm...>]

Hi Dean,

On Wed, Sep 3, 2008 at 07:47, Dean Michael Berris
<mik...@gm...> wrote:
>
> I think it's all about whether we want to live with the test failure
> in Windows based on a perfectly valid test that exposes a bug in
> Python in Windows. In this case I think it's alright for us to live
> with it -- we can mark it as an expected failure if we're in Windows.

I don't see how that's an improvement over saving test.xml with
LF-only line endings, and get consistent test results...? I understood
Divye's point to be that if we did that, we would mask something else.

Wait... OK, I think I see what's happening:

1) test.xml always contains CRLF, even on Linux
2) On Linux, the Python server serves test.xml with CRLF endings intact
3) If we change test.xml to LF-only, we have worse test coverage for
line ending independence

Is that it?

> Perhaps a patch to the test to reflect this would be very welcome. :)

It's included in the patch I sent last night -- in Win32
configurations the test code strips all CRs from the source text
document. But maybe a dedicated test would be better to demonstrate
this.

Thanks,
- Kim