Re: [cpp-netlib-devel] localhost_tests cleanup

[Dean M. B. <mik...@gm...>]

Hi Kim,

Thanks, I'll apply the patch and test. If the tests pass, then I guess
it should be alright to commit.

I just got a message from Sourceforge though that write access will be
disabled until further notice, so it may take a while before this gets
into the repository.

More later! :)

On Wed, Sep 3, 2008 at 5:01 AM, Kim Gräsman <kim...@gm...> wrote:
> Hello,
>
> I've spent a couple of hours getting used to Boost, cpp-netlib, etc,
> and spent those cleaning up localhost_tests.cpp. Here's a patch that
> does a lot:
>
> - extracts http_test_server.hpp wrapping ShellExecuteEx/fork
> - http_test_server no longer stops with an error dialog if Python is
> not installed, but rather fails with an error message on the console
> - uses global fixture for starting/stopping the Python test server
> (independent of test run order)
> - cleaned some file i/o out of text_file_query and binary_file_query
> into helper function readfile
> - consistent tab size in localhost_tests.cpp
> - added adjust_lineendings, used with text_file_query to make the
> source data match the output from the Python server (LF-only
> line-endings)
>
> I wish I could've offered these one-by-one, but it would turn into a
> versioning nightmare to apply the patches in order. I think most of
> the changes are benign, I'm a little doubtful of the last one, but
> until I've fully understood Divye, this is a workaround to make it
> right on Windows.
>
> Hope it helps,
> - Kim
>
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & win great prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________
> Cpp-netlib-devel mailing list
> Cpp...@li...
> https://lists.sourceforge.net/lists/listinfo/cpp-netlib-devel
>
>



-- 
Dean Michael C. Berris
Software Engineer, Friendster, Inc.