From: K. G. <kim...@gm...> - 2008-09-02 21:01:37
|
Hello, I've spent a couple of hours getting used to Boost, cpp-netlib, etc, and spent those cleaning up localhost_tests.cpp. Here's a patch that does a lot: - extracts http_test_server.hpp wrapping ShellExecuteEx/fork - http_test_server no longer stops with an error dialog if Python is not installed, but rather fails with an error message on the console - uses global fixture for starting/stopping the Python test server (independent of test run order) - cleaned some file i/o out of text_file_query and binary_file_query into helper function readfile - consistent tab size in localhost_tests.cpp - added adjust_lineendings, used with text_file_query to make the source data match the output from the Python server (LF-only line-endings) I wish I could've offered these one-by-one, but it would turn into a versioning nightmare to apply the patches in order. I think most of the changes are benign, I'm a little doubtful of the last one, but until I've fully understood Divye, this is a workaround to make it right on Windows. Hope it helps, - Kim |