From: Divye K. <div...@gm...> - 2008-09-02 15:59:21
|
On Tue, Sep 2, 2008 at 7:19 PM, Kim Gräsman <kim...@gm...> wrote: > Hi Divye, > > On Tue, Sep 2, 2008 at 15:43, Divye Kapoor <div...@gm...> wrote: > >> > >> Attached is a patch for the modified test.xml and adjusted > >> localhost_tests.cpp. Unfortunately, TortoiseSVN seems to have trouble > >> handling changes only in line endings, so whoever commits this may > >> need to alter test.xml manually to make it use Unix line-endings. > > > > I would not advise such a commit as it atleast prevents *us* from munging > > line endings while handling text bodies. > > I'm not sure I understand... Are you saying it could mask bugs in > cpp-netlib? Could you elaborate? > As of now, we are not touching the response body given by the server. Right now, we know that the python server is returning fewer characters of the body than expected and we are retaining it bit for bit, allowing the test to fail on Windows. However, if we do need to process the body at some other stage, say to support multipart responses, it would be helpful to retain the test with the CRLF line endings to ensure that non-native line endings are being processed properly by the library while handling the body. Divye -- An idealist is one who, on noticing that a rose smells better than a cabbage, concludes that it will also make better soup. H. L. Mencken (1880 - 1956) My official web site: http://people.iitr.ernet.in/shp/061305/ Webmaster: http://www.drkapoorsclinic.com Blog: http://divyekapoor.blogspot.com |