Re: [cpp-netlib-devel] [commit] Patch for header and body processing inhttp::client

[Divye K. <div...@gm...>]

Glyn,
   Yes, those patches are related to that issue.
   I have fixed 3 issues in the patch:
1. Headers such as "Content-Type: 117" were being stored as
("Content-type", "117\r") in the headers map.
2. The body was not being properly stored because an empty line was
being looked for after the headers response whereas parsing the
response yielded a line containing "\r", thus causing the actual body
content to be parsed.
3. Formatted I/O functions were being used on the socket_stream
whereas we were transferring unformatted data (HTTP doesn't know
anything about the payload). I have changed the code to use
unformatted I/O functions.

Tests for issues 1 and 2 have been committed in the localhost_tests
suite (content_length_header_test, text_file_query, binary_file_query)

If the tests can be verified to pass, then we can close the issue.

Divye

On Wed, Jul 2, 2008 at 12:34 PM, Glyn Matthews <gly...@gm...> wrote:
> Divye,
>
> Is this related to the reported patch:
> http://tinyurl.com/4cjwo7
>
> ?
>
> Glyn
>
>
> 2008/7/2 Dean Michael C. Berris <dmb...@fr...>:
>>
>> Thanks Divye,
>>
>> I'll go take a look when I get the time. I think it would be worth
>> checking whether Windows is sending/receiving the file in wide character
>> mode.
>>
>> --
>> Dean Michael Berris
>> Software Engineer, Friendster, Inc.
>>
>> > -----Original Message-----
>> > From: cpp...@li...
>> > [mailto:cpp...@li...] On
>> > Behalf Of Divye Kapoor
>> > Sent: Wednesday, July 02, 2008 8:19 AM
>> > To: C++ Networking Library Developers Mailing List
>> > Subject: [cpp-netlib-devel] [commit] Patch for header and
>> > body processing inhttp::client
>> >
>> > Hi,
>> >   I've removed the extra \r being inserted with every http header and
>> > ensured proper newline processing for the body of the message. The
>> > only problem I'm facing is that on Windows/MSVC the actual size of a
>> > text file and the size of the transferred content don't match whereas
>> > the binary file transfer is perfect. (look at the text_file_query
>> > test) I have not been able to trace the reason for this. Is the error
>> > in my test code or in the implementation of http::client? Strangely,
>> > the same test succeeds on linux. Is it some line ending issue?
>> >
>> > Now, all the tests should run automatically (nearly) on both linux and
>> > windows. If you face any issues, please mail!
>> >
>> > Divye Kapoor
>> >
>> >
>> > --
>> > Whether the chicken crossed the road or the road moved beneath the
>> > chicken depends upon your frame of reference.
>> > My official web site: http://people.iitr.ernet.in/shp/061305/
>> >
>> > --------------------------------------------------------------
>> > -----------
>> > Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
>> > Studies have shown that voting for your favorite open source project,
>> > along with a healthy diet, reduces your potential for chronic lameness
>> > and boredom. Vote Now at http://www.sourceforge.net/community/cca08
>> > _______________________________________________
>> > Cpp-netlib-devel mailing list
>> > Cpp...@li...
>> > https://lists.sourceforge.net/lists/listinfo/cpp-netlib-devel
>> >
>>
>> -------------------------------------------------------------------------
>> Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
>> Studies have shown that voting for your favorite open source project,
>> along with a healthy diet, reduces your potential for chronic lameness
>> and boredom. Vote Now at http://www.sourceforge.net/community/cca08
>> _______________________________________________
>> Cpp-netlib-devel mailing list
>> Cpp...@li...
>> https://lists.sourceforge.net/lists/listinfo/cpp-netlib-devel
>
>
> -------------------------------------------------------------------------
> Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
> Studies have shown that voting for your favorite open source project,
> along with a healthy diet, reduces your potential for chronic lameness
> and boredom. Vote Now at http://www.sourceforge.net/community/cca08
> _______________________________________________
> Cpp-netlib-devel mailing list
> Cpp...@li...
> https://lists.sourceforge.net/lists/listinfo/cpp-netlib-devel
>
>



-- 
Whether the chicken crossed the road or the road moved beneath the
chicken depends upon your frame of reference.
My official web site: http://people.iitr.ernet.in/shp/061305/