Re: [cpp-netlib-devel] Review of http::message

[Michael D. <mi...@mi...>]

I like it!  Makes me wonder though, if maybe we should just make all  
these part of the http "message traits," and do away with the "parser  
traits" concept altogether?

-Mike

On Apr 21, 2008, at 1:36 AM, Dean Michael C. Berris wrote:

> Okay, so just now I chopped up parser_traits into the following files:
> 	
> network/protocol/http/traits/impl/cookie_name.ipp
> network/protocol/http/traits/impl/cookie_value.ipp
> network/protocol/http/traits/impl/header_name.ipp
> network/protocol/http/traits/impl/header_value.ipp
> network/protocol/http/traits/impl/method.ipp
> network/protocol/http/traits/impl/post_content.ipp
> network/protocol/http/traits/impl/query_name.ipp
> network/protocol/http/traits/impl/query_string.ipp
> network/protocol/http/traits/impl/query_value.ipp
> network/protocol/http/traits/impl/resource.ipp
> network/protocol/http/traits/impl/status_message.ipp
> network/protocol/http/traits/parser_traits.hpp
>
> In this approach, we then use the tag dispatch to get the appropriate
> typedef for the MAX nested static value:
>
> 	http::cookie_name<http::message_tag>::MAX; // 1024u
>
> Mike, please let me know when you think we can start changing the  
> parser
> implementation(s) to use the newer traits mechanisms.
>
> I like this rate that we're proceeding. I'll try writing more tests to
> satisfy some of Divye's curiousity -- or if you're already trying your
> hand at those Divye, please let me know so we can coordinate
> accordingly.
>
> Have a good day guys!
>
> --
> Dean Michael Berris
> Software Engineer, Friendster, Inc.
> <dmb...@fr...>
> +639287291459
>
>
>> -----Original Message-----
>> From: cpp...@li...
>> [mailto:cpp...@li...] On
>> Behalf Of Dean Michael C. Berris
>> Sent: Monday, April 21, 2008 2:15 PM
>> To: C++ Networking Library Developers Mailing List
>> Subject: Re: [cpp-netlib-devel] Review of http::message
>>
>>> -----Original Message-----
>>> From: cpp...@li...
>>> [mailto:cpp...@li...] On
>> Behalf Of
>>> Michael Dickey
>>> Sent: Monday, April 21, 2008 4:20 AM
>>> To: C++ Networking Library Developers Mailing List
>>> Subject: Re: [cpp-netlib-devel] Review of http::message
>>>
>>> The new approach sounds (and now, looks) good to me.
>>>
>>
>> Nice. That's good to know Mike. :)
>>
>>> Although I noticed that parser_traits.hpp appears to be
>> just a copy of
>>> the traits.hpp file (the parser constants seem to have been lost
>>> somewhere in the update).  Whether these are called
>> 'parser_traits',
>>> 'parser_consts' or anything else is fine with me =)
>>>
>>
>> Yeah, I haven't gotten to chopping that file up just yet. I'm
>> still mulling around the name(s), but I think I'll just go
>> first with parser_consts or a more fine-grained approach at
>> decomposing the various constants contained in parser_traits.
>> I'll let you know when I get something in soon. :)
>>
>> Thanks Mike!
>>
>> --
>> Dean Michael Berris
>> Software Engineer, Friendster, Inc.
>> <dmb...@fr...>
>> +639287291459
>>
>>
>> --------------------------------------------------------------
>> -----------
>> This SF.net email is sponsored by the 2008 JavaOne(SM)
>> Conference Don't miss this year's exciting event. There's
>> still time to save $100.
>> Use priority code J8TL2D2.
>> http://ad.doubleclick.net/clk;198757673;13503038;p?http://java
>> .sun.com/javaone
>> _______________________________________________
>> Cpp-netlib-devel mailing list
>> Cpp...@li...
>> https://lists.sourceforge.net/lists/listinfo/cpp-netlib-devel
>>
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
> Don't miss this year's exciting event. There's still time to save  
> $100.
> Use priority code J8TL2D2.
> http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
> _______________________________________________
> Cpp-netlib-devel mailing list
> Cpp...@li...
> https://lists.sourceforge.net/lists/listinfo/cpp-netlib-devel
>