From: Allister L. S. <all...@gm...> - 2008-09-03 00:15:21
|
Hi, I've committed my first attempt at MIME. Sorry I haven't even compiled it yet (bad practice, I promise won't happen again!) but I have to sleep for now and hopefully get your comments, suggestions and modifications/patches tomorrow after work :-) Cheers, Allister |
From: Allister L. S. <all...@gm...> - 2008-09-03 00:20:57
|
Oops, I forgot: it's in boost/network/protocol/mime.hpp On Wed, Sep 3, 2008 at 2:15 AM, Allister Levi Sanchez < all...@gm...> wrote: > Hi, > > I've committed my first attempt at MIME. Sorry I haven't even compiled it > yet (bad practice, I promise won't happen again!) but I have to sleep for > now and hopefully get your comments, suggestions and modifications/patches > tomorrow after work :-) > > Cheers, > Allister > > |
From: Dean M. C. B. <dmb...@fr...> - 2008-09-03 05:12:47
|
Hi Allister, > -----Original Message----- > From: cpp...@li... > [mailto:cpp...@li...] On > Behalf Of Allister Levi Sanchez > Sent: Wednesday, September 03, 2008 8:21 AM > To: C++ Networking Library Developers Mailing List > Subject: Re: [cpp-netlib-devel] mime (http integration) > > Oops, I forgot: it's in boost/network/protocol/mime.hpp > Thanks, This time I think we may have to move the mime processing code outside of boost/network/protocol and just move it into boost/network/utils or something similar. A lot of the URI parsing stuff can also be moved out of boost/network/protocol/http and into its own component into boost/network/utils. I'll think more about it before making any changes/moves. It would also be a good idea to branch off for MIME development (mime_integration) perhaps. More about it as my brain starts picking up. ;) -- Dean Michael Berris Software Engineer, Friendster, Inc. |
From: Allister L. S. <all...@gm...> - 2008-09-03 06:24:08
|
Hi Dean and everyone, On Wed, Sep 3, 2008 at 7:12 AM, Dean Michael C. Berris < dmb...@fr...> wrote: > > This time I think we may have to move the mime processing code outside > of boost/network/protocol and just move it into boost/network/utils or > something similar. A lot of the URI parsing stuff can also be moved out > of boost/network/protocol/http and into its own component into > boost/network/utils. Hmmm, isn't MIME itself a protocol ( http://en.wikipedia.org/wiki/Category:Application_layer_protocols)? And speaking of utils, the message encoding/decoding (such as to/from base64 that you have in http) could also be added there, right? > > > I'll think more about it before making any changes/moves. > > It would also be a good idea to branch off for MIME development > (mime_integration) perhaps. > > More about it as my brain starts picking up. ;) > Yes, maybe branching off for MIME would be a good idea -- once we've decided where to put it hehe... Cheers, Allister |
From: Dean M. B. <mik...@gm...> - 2008-09-03 06:39:46
|
On Wed, Sep 3, 2008 at 2:24 PM, Allister Levi Sanchez <all...@gm...> wrote: > > On Wed, Sep 3, 2008 at 7:12 AM, Dean Michael C. Berris > <dmb...@fr...> wrote: >> >> This time I think we may have to move the mime processing code outside >> of boost/network/protocol and just move it into boost/network/utils or >> something similar. A lot of the URI parsing stuff can also be moved out >> of boost/network/protocol/http and into its own component into >> boost/network/utils. > > Hmmm, isn't MIME itself a protocol > (http://en.wikipedia.org/wiki/Category:Application_layer_protocols)? > Oh, right. :D My bad. :) > And speaking of utils, the message encoding/decoding (such as to/from base64 > that you have in http) could also be added there, right? > Yes, Base64 encoding (not yet implemented) will have to go into utils. >> >> I'll think more about it before making any changes/moves. >> >> It would also be a good idea to branch off for MIME development >> (mime_integration) perhaps. >> >> More about it as my brain starts picking up. ;) > > Yes, maybe branching off for MIME would be a good idea -- once we've decided > where to put it hehe... > I think you're correct with putting mime into protocol/ -- I imagine it would need to be split up to multiple files and in its own directory protocol/mime/ aside from just protocol/mime.hpp ? -- Dean Michael C. Berris Software Engineer, Friendster, Inc. |
From: Dean M. B. <mik...@gm...> - 2008-09-15 05:14:46
|
Hi Allister, Any news on the branch/library? Have you got the chance to write the unit tests for the library yet? :D Looking forward to the code... ;-) On Wed, Sep 3, 2008 at 2:39 PM, Dean Michael Berris <mik...@gm...> wrote: > On Wed, Sep 3, 2008 at 2:24 PM, Allister Levi Sanchez [snip] -- Dean Michael C. Berris Software Engineer, Friendster, Inc. |
From: Allister L. S. <all...@gm...> - 2008-09-15 08:07:34
|
Hi Dean and everyone, On Mon, Sep 15, 2008 at 7:14 AM, Dean Michael Berris <mik...@gm... > wrote: > Hi Allister, > > Any news on the branch/library? > > Have you got the chance to write the unit tests for the library yet? :D > > Looking forward to the code... ;-) > Sorry, I got too caught up in other things right now. Also, I'm not yet sure if my implementation in mime.hpp is consistent with the your idea of how it's gonna be used. Could you or anyone please have a good look at the code and see if it's handy enough to be used with the http library (and other foreseeable protocols that will be implemented)? Also, I have to admit my grasp of modern C++ idioms and networking protocols is not that good (yet), so I would appreciate if someone could give me a good lecture/critique of my implementation. Cheers, Allister |
From: Dean M. B. <mik...@gm...> - 2008-09-15 08:17:22
|
Hi Allister, On Mon, Sep 15, 2008 at 4:07 PM, Allister Levi Sanchez <all...@gm...> wrote: > > > Sorry, I got too caught up in other things right now. It's alright. It happens to the best of us. :) > Also, I'm not yet > sure if my implementation in mime.hpp is consistent with the your idea of > how it's gonna be used. Could you or anyone please have a good look at the > code and see if it's handy enough to be used with the http library (and > other foreseeable protocols that will be implemented)? Can you give me (or everyone) an idea as to how you intend the library to be used (in code, preferably as a set of unit tests) so that we can continue to work on the library? :-) > Also, I have to > admit my grasp of modern C++ idioms and networking protocols is not that > good (yet), so I would appreciate if someone could give me a good > lecture/critique of my implementation. > If we had something like a reviewboard (http://code.google.com/p/reviewboard/) installation then this would be way easier. Besides, it doesn't have to go modern C++ in the first drop -- we can work on that as it goes along. :-) Do you have concrete usage scenarios you'd like to first be able to address which can be expressed in a simple unit test so that we can go about writing it incrementally? -- Dean Michael C. Berris Software Engineer, Friendster, Inc. |