From: Dean M. B. <mik...@gm...> - 2010-06-04 04:57:57
|
On Fri, Jun 4, 2010 at 7:37 AM, Matt Trentini <mat...@gm...> wrote: > Heya Dean, > >> Yes, I'm working on it at the moment. On the 0.7-devel branch, I shall >> be pushing soon a fix that allows users to define the >> BOOST_NETWORK_NO_HTTPS .... > > Great, thanks for this! > You're welcome. :) > But have you considered making HTTPS an opt-in feature instead? So > you'd have to define BOOST_NETWORK_HTTPS to *allow* HTTPS connections. > I have, and the code's really set up to make that easy to change. > I'm not of a strong opinion either way but, in particular, I suspect > that the most common complaint we'll face from devs new to cpp-netlib > is that "the code doesn't compile" because they didn't know to add a > #define or a dependency to OpenSSL. > Yeah, especially on Windows. I think I'll just fix that and make it an opt-in feature instead -- just because I'm tired of fighting it and I think limiting the requirements on non-Boost libraries would be a good thing. Expect me to change this to: BOOST_NETWORK_ENABLE_HTTPS In my next push. Thanks to you, Erik, and Fernando for giving me enough reasons to change this and actually do it. :) -- Dean Michael Berris deanberris.com |
From: Darren G. <dar...@gm...> - 2010-06-04 07:47:37
|
Hey Dean, On 4 June 2010 05:57, Dean Michael Berris <mik...@gm...> wrote: > On Fri, Jun 4, 2010 at 7:37 AM, Matt Trentini <mat...@gm...> > wrote: > > > I'm not of a strong opinion either way but, in particular, I suspect > > that the most common complaint we'll face from devs new to cpp-netlib > > is that "the code doesn't compile" because they didn't know to add a > > #define or a dependency to OpenSSL. > > > > Yeah, especially on Windows. > > I think I'll just fix that and make it an opt-in feature instead -- > just because I'm tired of fighting it and I think limiting the > requirements on non-Boost libraries would be a good thing. > > Expect me to change this to: > > BOOST_NETWORK_ENABLE_HTTPS > > In my next push. > > Thanks to you, Erik, and Fernando for giving me enough reasons to > change this and actually do it. :) > Cool! This is a bit of a pain each time I clean out my PC. Any barriers to entry are best avoided, so this is a good move. Cheers, Darren |
From: Dean M. B. <mik...@gm...> - 2010-06-05 13:04:25
|
On Fri, Jun 4, 2010 at 3:47 PM, Darren Garvey <dar...@gm...> wrote: > > On 4 June 2010 05:57, Dean Michael Berris <mik...@gm...> wrote: >> >> Expect me to change this to: >> >> BOOST_NETWORK_ENABLE_HTTPS >> >> In my next push. >> >> Thanks to you, Erik, and Fernando for giving me enough reasons to >> change this and actually do it. :) > > Cool! This is a bit of a pain each time I clean out my PC. Any barriers to > entry are best avoided, so this is a good move. > Thanks, I'm in the final stages of testing and pushing in a few. Change committed locally, please expect an update on the branch soon. Have a great weekend everyone! -- Dean Michael Berris deanberris.com |
From: Darren G. <dar...@gm...> - 2010-06-05 14:18:02
|
On 5 June 2010 14:03, Dean Michael Berris <mik...@gm...> wrote: > On Fri, Jun 4, 2010 at 3:47 PM, Darren Garvey <dar...@gm...> > wrote: > > > > On 4 June 2010 05:57, Dean Michael Berris <mik...@gm...> > wrote: > >> > >> Expect me to change this to: > >> > >> BOOST_NETWORK_ENABLE_HTTPS > >> > >> In my next push. > >> > >> Thanks to you, Erik, and Fernando for giving me enough reasons to > >> change this and actually do it. :) > > > > Cool! This is a bit of a pain each time I clean out my PC. Any barriers > to > > entry are best avoided, so this is a good move. > > > > Thanks, I'm in the final stages of testing and pushing in a few. > Change committed locally, please expect an update on the branch soon. > Looking forward to it. Cheers, Darren |
From: Dean M. B. <mik...@gm...> - 2010-06-06 13:54:46
|
On Sat, Jun 5, 2010 at 10:17 PM, Darren Garvey <dar...@gm...> wrote: > On 5 June 2010 14:03, Dean Michael Berris <mik...@gm...> wrote: >> >> Change committed locally, please expect an update on the branch soon. > > Looking forward to it. > And it's there. :) Sorry for the late update, weekend family time currently trumps opensource development. Have a great one guys! -- Dean Michael Berris deanberris.com |
From: Nelson, E. - 2 <eri...@ba...> - 2010-06-07 14:28:57
|
Dean Michael Berris wrote: > And it's there. :) Yay! Now I won't have to separately maintain that file any more. > Sorry for the late update, weekend family time currently trumps > opensource development. No need to be sorry, family's more important. Erik |