Glyn!
On Tue, Dec 1, 2009 at 5:12 AM, Glyn Matthews <gly...@gm...> wrote:
> Dean,
>
>
> I have some comments:
>
> Your URI tests indicate that you have a function "protocol". In the
> implementation, you refer to "scheme". Shouldn't "protocol" be named
> "scheme"?
Yes, my bad. scheme and protocol can both be put there. Let me fix
that, unless you already have that done. :D
> I added a couple of extra tests for the URI, but they're not the negative
> ones you were looking for ;)
No worries, more tests for more situations in my book would be better. :)
> There is a failing test in
> localhost_tests.cpp, I think the file server/test.xml has different line
> endings, meaning that the content-length value is different.
Yeah, we really have to adopt some convention similar to the Boost
guidelines about subversion. Or when we move to Git we can configure
that better. ;)
> Also, I added a very simple example, a wget clone that uses URI and
> http::client. It works, but it does show up a couple of problems with the
> way the uri and client aren't well integrated.
Yup, I think it means we'll need overloads or just plain replace the
interface of the client methods that take an http::uri as a parameter
instead of just a string.
>
> I'll continue to make piecemeal updates as and when I can.
>
Sweet, thanks for the update Glyn!
--
Dean Michael Berris
blog.cplusplus-soup.com | twitter.com/mikhailberis
linkedin.com/in/mikhailberis | facebook.com/dean.berris | deanberris.com
|
