Menu ▾ ▴

#698 bugfix/fix-vpa

closed
nobody
None
2025-03-20
2025-03-17
Anonymous
No

Originally created by: klinch0

Summary by CodeRabbit

  • New Features
    • Introduced enhanced resource management options across multiple applications with configurable settings for resource limits and requests, including preset selections.
    • Added new resource management parameters for HAProxy, Nginx, Kafka, and other components, allowing users to specify resource limits and presets.
    • Added new feature gate AutoResourceLimitsGate to KubeVirt for improved resource management capabilities.
    • Updated resource specifications for various components in the ingress-nginx, seaweedfs, and monitoring applications, enhancing resource allocation strategies.
  • Documentation
    • Updated configuration guides to include the new resource parameters and presets.
  • Chores
    • Bumped version numbers and updated release metadata for several applications, reflecting overall improvements.

Related

Tickets: #752
Tickets: #754

Discussion

  • Anonymous

    Anonymous - 2025-03-17

    Originally posted by: coderabbitai[bot]

    Walkthrough

    The changes update chart versions and version mappings while enhancing resource management across multiple applications. New parameters, presets, and conditional logic have been added to README files, values, schemas, and templates. Several Helm deployment files now check for custom resource values or fallback to preset configurations. Additionally, standardized kubeConfig secret references and minor annotations (including a new feature gate) have been introduced.

    Changes

    File(s) Change Summary
    packages/apps/{http-cache,kafka,kubernetes,tcp-balancer,tenant,vpn}/Chart.yaml
    packages/extra/{etcd,monitoring,seaweedfs}/Chart.yaml
    packages/apps/versions_map    		 Updated chart version numbers and version mappings following semantic versioning.
    packages/apps/{http-cache,kafka,kubernetes,tcp-balancer,vpn}/(README.md, values.yaml, values.schema.json, templates/*)
    packages/extra/{etcd/values.yaml, monitoring/**/*}
    packages/extra/seaweedfs/templates/{seaweedfs.yaml,vpa.yaml}
    packages/system/ingress-nginx/values.yaml    		 Added new resource parameters, presets, and Mustache templates; introduced conditional logic for resource allocation (custom values vs. presets) across applications.
    packages/apps/kubernetes/templates/helmreleases/{cert-manager-crds.yaml,cert-manager.yaml,cilium.yaml,csi.yaml,fluxcd.yaml,ingress-nginx.yaml,monitoring-agents.yaml} Updated kubeConfig secret references by renaming secrets (-kubeconfig → -admin-kubeconfig) and adding a key field with value super-admin.svc.
    packages/apps/tenant/templates/namespace.yaml
    packages/system/kubevirt/templates/kubevirt-cr.yaml    		 Introduced a new namespace annotation and enabled the AutoResourceLimitsGate feature in the kubevirt configuration.

    Sequence Diagram(s)

    sequenceDiagram
    participant Values as Helm Values
    participant Template as Helm Template Engine
    participant Deployment as Kubernetes Deployment
    Values->>Template: Provide resource configuration
    alt Custom resources provided (.Values.resources defined)
      Template->>Deployment: Render custom resource settings via toYaml
    else Preset selected (.Values.resourcesPreset ≠ "none")
      Template->>Deployment: Render preset resource configuration via preset template
    else
      Template->>Deployment: Render default settings
    end

    Poem

    I'm a bunny on the run,
    Hoping through code with carrot fun,
    New versions hopping high and bright,
    Resource presets set things just right,
    With secret keys that gleam in sight,
    I nibble changes, light and spry –
    CodeRabbit cheers as bytes hop by!

    🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=cozystack/cozystack&utm_content=698): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit <commit_id>, please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai generate docstrings` to [generate docstrings](https://docs.coderabbit.ai/finishing-touches/docstrings) for this PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements. </commit_id>
     

  • Anonymous

    Anonymous - 2025-03-20

    Ticket changed by: lllamnyp

    • status: open --> closed
     

Log in to post a comment.